Skip to content

Document explicit types for numeric date formats - #1042

Merged
quinnj merged 1 commit into
JuliaData:mainfrom
DylanModesitt:docs-clarify-dateformat
Oct 15, 2026
Merged

quinnj merged 1 commit into
JuliaData:mainfrom
DylanModesitt:docs-clarify-dateformat

Conversation

@DylanModesitt

@DylanModesitt DylanModesitt commented Oct 22, 2022 •

Copy link
Copy Markdown
Contributor

Digit-only dates such as 20190101 infer as integers when only dateformat="yyyymmdd" is provided. Clarify that numeric detection takes precedence, and show types=Dict(:date => Date) so callers can request dates.

Adapted from @DylanModesitt's original clarification for #1040 to the current documentation. This changes two documentation files and preserves type inference.

Validation: strict full documentation builds on Julia 1.10.11 and 1.13.1, including the new example's type and value assertions. Public checks cover both integer-like yyyymmdd and floating-point-like yyyy.mm data, with string, DateFormat, and per-column dictionary formats on both versions. All 18 exact-head checks pass (16 native jobs and both coverage checks). All nine coverage uploads were accepted for 32b2c2ce8a697683726169996d1e0f3af60302c9 in JuliaData/CSV.jl and processed, with 95.75% coverage. Merge still requires independent approval.

Co-authored by Codex

AI disclosure: This work was prepared with assistance from OpenAI Codex.

@quinnj

quinnj commented Sep 19, 2026

Copy link
Copy Markdown
Member

[Reviewed by AI] Scoped review of the documentation change at df3ffe8.

The clarification still matches current main (ff0c032): on Julia 1.12.6, yyyymmdd input infers Int64, and yyyy.mm input infers Float64. Adding types=Dict(:date => Date) parses both as dates. Include that explicit-type example so readers can act on the warning.

Please rebase or transplant the small documentation change into the current “Missing values and value syntax” section. GitHub currently reports this PR as conflicting, with 145 changed files; the intended commit changes only the dateformat documentation. I tested the examples on current main, not the historical PR's full suite.

Adapt Dylan Modesitt's numeric dateformat clarification to the current
CSV documentation and add an evaluated compact-date example.

AI disclosure: This work was prepared with assistance from OpenAI Codex.

Co-authored-by: Dylan Modesitt <dylanmodesitt@gmail.com>
@quinnj quinnj changed the title clarify dateformat docs w.r.t. primitive types Document explicit types for numeric date formats Oct 4, 2026
@quinnj
quinnj force-pushed the docs-clarify-dateformat branch from df3ffe8 to 32b2c2c Compare October 4, 2026 09:16
@codecov

codecov Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.75%. Comparing base (a0335ff) to head (32b2c2c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1042   +/-   ##
=======================================
  Coverage   95.75%   95.75%           
=======================================
  Files           9        9           
  Lines        5489     5489           
=======================================
  Hits         5256     5256           
  Misses        233      233           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@quinnj quinnj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[comment generated via AI] Verified on current main with Julia 1.12: yyyymmdd digits infer as Int64 with only dateformat, types=Dict(:date => Date) reads them as dates, and the docs build runs the new example. Thanks @DylanModesitt.

@quinnj
quinnj merged commit ac3b0eb into JuliaData:main Oct 15, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants