Repository navigation
Document explicit types for numeric date formats - #1042
Conversation
|
[Reviewed by AI] Scoped review of the documentation change at The clarification still matches current main ( Please rebase or transplant the small documentation change into the current “Missing values and value syntax” section. GitHub currently reports this PR as conflicting, with 145 changed files; the intended commit changes only the dateformat documentation. I tested the examples on current main, not the historical PR's full suite. |
Adapt Dylan Modesitt's numeric dateformat clarification to the current CSV documentation and add an evaluated compact-date example. AI disclosure: This work was prepared with assistance from OpenAI Codex. Co-authored-by: Dylan Modesitt <dylanmodesitt@gmail.com>
df3ffe8 to
32b2c2c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1042 +/- ##
=======================================
Coverage 95.75% 95.75%
=======================================
Files 9 9
Lines 5489 5489
=======================================
Hits 5256 5256
Misses 233 233 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
quinnj
left a comment
There was a problem hiding this comment.
[comment generated via AI] Verified on current main with Julia 1.12: yyyymmdd digits infer as Int64 with only dateformat, types=Dict(:date => Date) reads them as dates, and the docs build runs the new example. Thanks @DylanModesitt.
Digit-only dates such as
20190101infer as integers when onlydateformat="yyyymmdd"is provided. Clarify that numeric detection takes precedence, and showtypes=Dict(:date => Date)so callers can request dates.Adapted from @DylanModesitt's original clarification for #1040 to the current documentation. This changes two documentation files and preserves type inference.
Validation: strict full documentation builds on Julia 1.10.11 and 1.13.1, including the new example's type and value assertions. Public checks cover both integer-like
yyyymmddand floating-point-likeyyyy.mmdata, with string,DateFormat, and per-column dictionary formats on both versions. All 18 exact-head checks pass (16 native jobs and both coverage checks). All nine coverage uploads were accepted for32b2c2ce8a697683726169996d1e0f3af60302c9in JuliaData/CSV.jl and processed, with 95.75% coverage. Merge still requires independent approval.Co-authored by Codex
AI disclosure: This work was prepared with assistance from OpenAI Codex.