Repository navigation
Rewrite nested get/setindex handling - #12
Merged
Merged
Conversation
Contributor
Author
|
@aviks could I recruit you to both (1) merge this PR, and (2) transfer this to JuliaPlots (PlotlyLight is the primary dependent), my user account, or some other Julia org? |
Member
|
Do you want to make a release from here before moving? |
Contributor
Author
|
@aviks that would be great if you don't mind! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old EasyConfig would leave dangling
Configs around when getindex-ing keys that didn't exist, and then delete them explicitly withEasyConfig.delete_empty!or implicitly when callingBase.isempty(which is called duringBase.show).Since I originally wrote the package I've been meaning to do something better, and now I have:
Explanation in the README:
Other new features:
Configcan now wrap anyAbstractDict{Symbol,Any}, usesDict{Symbol,Any}by defaultdeepmerge/deepmerge!for merging nested configs