Repository navigation
Throw descriptive error in copy! into FixedSizeVector on axes mismatch - #195
Merged
Merged
Conversation
…match Avoids the `resize!` fallback of `copy!(::AbstractVector, ::AbstractVector)`. Fixes JuliaArrays#194 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
CI is completely blocked for the entire organisation by JuliaArrays/StaticArrays.jl#1360. Moving testing of that package to ParallelTestRunner would much alleviate the issue (I also upgraded the org, but that shouldn't stop from using resources more efficiently) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
==========================================
+ Coverage 92.85% 92.95% +0.10%
==========================================
Files 5 5
Lines 210 213 +3
==========================================
+ Hits 195 198 +3
Misses 15 15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #194.
copy!(::FixedSizeVector, ::AbstractVector)fell back to Base's vector method, which callsresize!on length mismatch (MethodError, also flagged by JET). It now checksaxes(dst) == axes(src), like Base'scopy!(::AbstractArray, ::AbstractArray), and throws anArgumentErrorthat shows both axes.With this PR, JET no longer reports the
resize!error for the example from the issue (Julia 1.13.1):🤖 Generated with Claude Code