Skip to content

fix: keep records raw output valid JSON - #73

Merged
JordanCoin merged 1 commit into
mainfrom
codex/issue-72-raw-json
Sep 26, 2026
Merged

JordanCoin merged 1 commit into
mainfrom
codex/issue-72-raw-json

Conversation

@JordanCoin

Copy link
Copy Markdown
Owner

Closes #72

Summary

  • keep progress output out of records search --raw
  • emit a strict JSON document through Typer
  • cover control-character escaping and JSON round-trip with the real CLI path

Verification

  • python -m pytest tests/test_records_cli.py -v
  • ruff check openfoia/cli.py tests/test_records_cli.py
  • ruff format --check openfoia/cli.py tests/test_records_cli.py
  • independent review: pass

The full suite reached 279 passed and 26 skipped; two pre-existing LLM extraction tests require an unavailable local LLM and failed unchanged.

Copilot AI lite review requested due to automatic review settings August 13, 2026 02:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

JordanCoin added a commit that referenced this pull request Sep 26, 2026
…n fixes

Integrate PRs #73–#77 with cross-PR regression fixes
@JordanCoin
JordanCoin merged commit 829e5d2 into main Sep 26, 2026
5 checks passed
JordanCoin pushed a commit that referenced this pull request Sep 26, 2026
Bump version to 4.2.0 and add the changelog entry for PRs #73-#78:
records filings (SEC filing history), per-source cross-reference
statuses, honest failure reporting in crossref and records search --raw,
and the full nine-source records search docs.

Minor bump: records filings is a new command; nothing is removed or
changed incompatibly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016LaGpHLuSRHzGARb38X7YS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

records search --raw emits unescaped control characters — output is not valid strict JSON

2 participants