Tighten brainstorming research gate and evidence contract - #2
Draft
Jonksar wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is submitting this PR? (required)
gpt-5.6-solat high reasoning for the skill change;gpt-5.6-lunaat high reasoning for every task-completion parent and research childWhat problem are you trying to solve?
The research step in obra#2116 depended on the model deciding that technology felt unfamiliar or that local context was insufficient. That misses the motivating failure: a confident but stale pg-boss recommendation did not feel unfamiliar. The first observable rewrite still under-triggered when work changed an existing third-party integration rather than introducing a dependency.
Maintainer feedback asked for one observable predicate, a mirrored gate, a positive source-evidence recipe, measured read-only compliance at N>=10, adversarial familiar-technology coverage, and honest runtime/cost reporting.
What does this PR change?
The brainstorming skill now applies one observable research gate after path-scaled clarification on every path. The gate covers behavior defined by an external library, service API, or protocol; dependency changes; difficult-to-reverse decisions; and version-sensitive API behavior.
When true, it dispatches exactly one focused read-only child, gives that child a source-specific evidence contract, waits, and consumes the findings in the selected path's probe plan, short design, or approach comparison. External projects require implementation and test links; closed services and protocols may use official versioned specifications and API documentation.
Is this change appropriate for the core library?
Yes. The failure and gate apply across languages, repositories, and domains. This adds no dependency or third-party integration; it changes only the general-purpose brainstorming workflow already proposed in obra#2116.
What alternatives did you consider?
Does this PR contain multiple unrelated changes?
No. The checklist, graph, explanatory prose, and evidence contract are representations of the same brainstorming research gate.
Existing PRs
This is not a competing upstream submission: it is the requested follow-up patch for obra#2116. obra#386 is the older feature request; obra#2063 supplied the three-path router this preserves. obra#1512 concerns recommendation comparison dimensions rather than source-grounded research dispatch. The closed PRs address broader brainstorming orientation or routing issues, not this observable gate and evidence contract.
Environment tested
gpt-5.6-lunagpt-5.6-lunagpt-5.6-lunagpt-5.6-solLocal skill editing and PR preparation used
gpt-5.6-solat high reasoning. Every executed task-completion agent used the same Luna configuration:gpt-5.6-luna,reasoning_effort = "high", Codex CLI 0.146.0, and the same config file. Both paired arms used the same ten task checksums, concurrency 3, and zero retries. The only intentional treatment difference was the exact final conditional research gate and evidence contract.New harness support (required if this PR adds a new harness)
Not applicable. This PR adds no harness support.
Evaluation
Initial prompt/session: The upstream change was motivated by brainstorming recommendations that were not grounded in established code, including a confident but stale pg-boss recommendation. This follow-up started from the five-point maintainer review on obra#2116.
Task-completion control vs experiment
The original battery mainly exercised internal library features; only its HTTPX multipart case clearly required external-contract research. This replacement battery was hand-picked for existing third-party APIs, libraries, and protocols. The control prompt asked Luna to implement and verify with no research gate. The experiment added the exact final conditional gate and evidence contract; it did not state that the gate was true.
Strict success was unchanged. Dateutil changed from control failure to experiment success, while kgateway changed from control success to experiment failure; the other strict outcomes were unchanged. Mean partial score declined by 0.1802 points and wall time increased by 54.3%. Recorded model cost happened to decrease by 43.4%, but N=10 is too small to treat that as a stable efficiency claim.
Per-test results
✅ strict means every verifier check passed; ❌ strict means at least one failed. Partial score retains feature-to-pass and pass-to-pass credit. Research marks come from trace-confirmed dedicated child sessions, not agent self-report.
uses:semanticspartialArgs/willContinueAPIRetry-AfterRouteAction.hash_policyAll 20 paired trials completed with zero infrastructure errors and zero retries. Trace inspection found exactly one research child in every experiment trial and none in control. All recorded parent and child turn contexts reported
gpt-5.6-lunaat high reasoning. The child traces contained nofile_changeorapply_patchevents; research used read/search/fetch operations and temporary files outside the task workspace.An earlier diagnostic experiment with the narrower “introduces or replaces a dependency” wording invoked research in only 4/10 of these expected-trigger cases. That result drove the explicit existing-library/service/protocol clause. It is not mixed into the paired performance table above, which reports only the exact final wording.
The requested use of Luna was honored for every task-completion parent and research child. No current-Claude arm was run.
Repository validation:
bash tests/writing-skills/test-render-graphs.sh— 8 passed, 0 failedbash tests/codex-plugin-sync/test-sync-to-codex-plugin.sh— passedTZ=UTC bash tests/codex/test-package-codex-plugin.sh— all passed from a normal clone (the script intentionally rejects linked worktrees)git diff --check— passedsuperpowersrepository; no docs checkout was modifiedRigor
superpowers:writing-skillsand completed adversarial pressure testing (results above)No Red Flags table, rationalization list, or human-partner language was modified.
Human review
This remains a draft coordination PR in Jonksar's fork. Joonatan must review the complete one-file diff before it is merged into the branch behind obra#2116.