Repository navigation
docs(upstream): run the three open PRs through the review panel - #149
Merged
Merged
Conversation
email-validator#182 cut to the 7-line early return and pushed after two panel rounds; arrow#1398 and fastjsonschema#233 held with close recommended. Records each reviewer's findings, the per-hunk numbers, the reviewed reply and closing texts, and updates the tracker rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran the three open upstream PRs through the process in
docs/UPSTREAM_PRS.md: why, per-hunk measurement, import time, documented settings, a differential, then three fresh reviewers per packet, up to three rounds.Outcomes
syntax.py, +1 changelog line) and force-pushed to the PR branch, with a new title and body. Round 1 failed the maintainer and facts reviewers. Both caught that the IDNA round trip does not "only lowercase" the domain, becauseuts46_remaphas already case-folded it, so.isascii()/.lower()were dead code. Round 2 passed all three. Mixed benchmark 54 → 30 µs per address. Import time, memory and all 11 documented settings are unchanged, and 60,044 differential cases are identical. The reply to "But why?" passed all three on round 3. Not posted.arrow.get("2013", "YYYY")raises. An 8-line factory-only version (lru_cacheplus the existingcache_size) gets all of the per-call gain, but the only real caller we found (ics 0.7.3) gets less than 5%. The closing comment used all three rounds and still has one facts finding (the failure depends on order), so it goes to the person signing off.{"properties": []}now compiles, and an all-stringenumaccepts non-string objects with a matching__eq__.performance.pythe gain is about 6%.Nothing was posted on any upstream thread. Every packet, verdict and piece of raw evidence is kept outside the repo.
Changes
docs/UPSTREAM_PRS.md:docs/PYTHON_SPEEDUPS.md: the PR URL and status cells for email-validator, arrow and fastjsonschema.Checks
Docs only, no crate, prompt or script changes.
cargo build/test/clippyand the acceptance scripts are unaffected and were not rerun. No em dashes were added.