-
Notifications
You must be signed in to change notification settings - Fork 0
fix(tg): Трейдинг text-button -> human report (was old treasury report) #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| """Tests: кнопка «Трейдинг» (текст) ведёт на человеческий отчёт.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import sys | ||
| from pathlib import Path | ||
|
|
||
| sys.path.insert(0, str(Path(__file__).resolve().parents[1])) | ||
|
|
||
| from tg_bot.trading_report import send_full_report # noqa: E402 | ||
|
|
||
|
|
||
| class FakeApi: | ||
| def __init__(self): | ||
| self.messages = [] | ||
|
|
||
| def send_message(self, chat_id, text, **kwargs): | ||
| self.messages.append(text) | ||
|
|
||
|
|
||
| def test_send_full_report_sends_data_and_llm_placeholder(): | ||
| api = FakeApi() | ||
| # LLM-секция реально вызовет балансер — для теста это не нужно, | ||
| # поэтому проверяем только структуру с патчем llm_section | ||
| import tg_bot.trading_report as mod | ||
|
|
||
| orig_llm = mod.llm_section | ||
| mod.llm_section = lambda snap: ["🤖 тестовая аналитика"] | ||
| try: | ||
| send_full_report(api, 123) | ||
| finally: | ||
| mod.llm_section = orig_llm | ||
| assert api.messages, "сообщения не отправлены" | ||
| assert any("Главное за 30 секунд" in m for m in api.messages) | ||
| assert "⏳ LLM-аналитика готовится…" in api.messages | ||
|
|
||
|
|
||
| def test_accounts_routes_trading_text_before_treasury(): | ||
| src = (Path(__file__).resolve().parents[1] / "tg_bot" / "accounts.py").read_text(encoding="utf-8") | ||
| # перехват стоит ДО treasury-интента | ||
| pos_trading = src.index('_t_norm in ("трейдинг"') | ||
| pos_treasury = src.index("_handle_treasury_intent(api, chat_id, text)") | ||
| assert pos_trading < pos_treasury | ||
| assert "send_full_report" in src | ||
|
|
||
|
|
||
| def test_callbacks_use_shared_helper(): | ||
| src = (Path(__file__).resolve().parents[1] / "tg_bot" / "callbacks.py").read_text(encoding="utf-8") | ||
| assert "from tg_bot.trading_report import send_full_report" in src |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 The Roast:
import threadingвнутри функцииsend_full_report— это как хранить запасной ключ в сейфе, ключ от которого у тебя в кармане. Работает, но каждый вызов тащит повторный импорт, и PEP 8 уже подписала petition на развод.🩹 The Fix: Перенеси
import threadingв начало файла. Модули из stdlib не должны импортироваться внутри функции без веской причины.📏 Severity: nitpick
Reply with
@kilocode-bot fix itto have Kilo Code address this issue.