Skip to content

Manifest validation updates - #21

Merged
Suvinthomas merged 2 commits into
mainfrom
manifest_validation
Oct 21, 2026
Merged

Suvinthomas merged 2 commits into
mainfrom
manifest_validation

Conversation

@Suvinthomas

@Suvinthomas Suvinthomas commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Description

Added a new ManifestValidator to validate manifest files before extraction processing. The validator performs:

Validation of required manifest properties and property data types.
Validation that at least one dimension and measure are specified.
Validation of measure and constraint definitions.
Validation of supported output formats.
Validation of constraint values against Metadata API domains.
Validation of requested years against Metadata API year scope definitions, with support for:
( and prior)
( onwards)
Explicit year lists
Generation of warnings where year scope validation cannot be performed due to missing or unsupported metadata formats.

Also added a comprehensive pytest suite covering:

Valid manifests
Missing required properties
Missing dimensions/measures
Invalid measure and constraint definitions
Invalid output formats
Constraint domain validation
Metadata lookup failures
Year scope validation scenarios and warning generation

This provides early validation of manifest configuration before extraction execution and aligns with the manifest validation requirements discussed with architecture.

Unit tests/Pytests :
image

@scottbw

scottbw commented Oct 20, 2026

Copy link
Copy Markdown
Member

This is a great start.

However I think its also worth adding:

  • ERROR: if a constraint has allowedValues that is an empty list
  • ERROR: if 'aggregation' attribute is present on a measure but is not one of sum, avg, min, max, count
  • ERROR: if there are duplicate dimensions

@Suvinthomas

Copy link
Copy Markdown
Contributor Author

@scottbw I have addressd the above error validations and added couple more pytests

image

@scottbw

scottbw commented Oct 21, 2026

Copy link
Copy Markdown
Member

Looks good @Suvinthomas !

@Suvinthomas
Suvinthomas merged commit 5773b4e into main Oct 21, 2026
3 checks passed
@Suvinthomas
Suvinthomas deleted the manifest_validation branch October 21, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants