Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Major-only pins select the wrong minor series, and the action output reports the unresolved input.
2 open findings
What changed in this PR
Adds partial CUDA version resolution to the action while preserving exact-version lookup for full semver inputs.
Changes:
- Resolves partial pins against available download versions.
- Adds regression tests and documents major.minor pins.
- Updates the shipped bundle.
| File | Description |
|---|---|
| src/version.ts | Parses partial pins and selects matching releases. |
| README.md | Documents version-pin behavior. |
| dist/index.js | Includes the updated resolver. |
| tests/version.test.ts | Tests pin resolution and unavailable versions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
myl7
force-pushed
the
major-minor-pins
branch
from
October 16, 2026 14:22
3e71e7b to
a6b7135
Compare
vhrabar
added a commit
to vhrabar/cuda-toolkit
that referenced
this pull request
Oct 19, 2026
…ion pins to newest patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
getVersion()parses thecudainput withnew SemVer(versionString), so any major.minor-only pin throws before installation starts:Strict semver requires all three components, but a major.minor pin ("install whatever patch of 12.6 is current") is a natural way to use this action, and it matches how the Linux network path actually installs (
cuda-nvcc-<major>-<minor>via apt, with apt resolving the patch).Change
Version not available.12.6) resolves to the newest listed patch of that series (currently12.6.3).12) resolves to the newest listed release of that major series.TypeError: Invalid Version: ....cudaoutput now reports the resolved installed version instead of the raw input.Jest covers pin resolution (major.minor and major-only), unavailable pins, and a full-but-unlisted version;
distis rebuilt.Complements #448 (CUDA 13.4 links) — with both,
cuda: 13.4works end to end.