ci(desktop): skip unused DMGs for signing-input builds - #461
Draft
Rinat S (rsolmano) wants to merge 5 commits into
Draft
ci(desktop): skip unused DMGs for signing-input builds#461Rinat S (rsolmano) wants to merge 5 commits into
Rinat S (rsolmano) wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid creating the unsigned macOS DMG that the private release pipeline discards. The triggering nightly failed in that redundant framework
hdiutil createstep withResource busybefore signing or publication.macos-signing-input-onlyto the public build action, restricted to macOS ARM64.build.mac.createDmg: falsethrough an explicit build-only environment value, without changing the normal package commands or SDK.Companion private workflow: https://github.com/JetBrains/thinkrail-signing/pull/9
Related issues
None.
Checklist
bun run lint,bun run typecheck,bun run testbun run e2e, orbun run e2e:fullwhen touching agent behavior)SPEC.md/ top-level specs updated to reflect any boundary, contract, or behavior changeVerification
Using repository-pinned Bun 1.4.0:
bun test apps/desktop/src/buildConfig.test.ts packages/artifact-tests/src/releaseArtifacts.test.ts— 33 passed, including default and input-only paths, target/value rejection, mandatory outputs and smoke gating.bun run check:deps,check:boundaries,check:seams,check:spec-surface— passed.bun run lint— passed with six pre-existing unused-suppression warnings; no new suppressions.bun run typecheckandbun run test— all 15 workspace tasks passed.bun run e2e— the initial complete run passed all 389 tests. After rebasing onto2f16bd63, the complete rerun was 388 passed / 1 failed ate2e/chat-order.spec.ts:117(scroll-to-top, assertion at line 204). This is the same previously established local baseline flake; chat/test sources are outside this diff, and no test was skipped or weakened. The E2E checkbox awaits an observed CI pass for the submitted head.THINKRAIL_MACOS_SIGNING_INPUT_ONLY=true bun run --cwd apps/desktop package:canaryin a fresh disposable worktree — passed; produced the exact macOS manifest and app archive, and no DMG. This was a build-only probe, not signed-install qualification.git diff --check— passed. Spec validation retains three unrelated pre-existing dangling task links.claude-opus-5review — Approve; both non-blocking cleanup suggestions were addressed (collector-owned smoke gating and explicit test-module ownership).Rollout and scope
Merge the private consumer first, then this public producer. Older sources may still create an unused DMG; the updated private handoff ignores it. No runtime updater changes, new dependencies, SDK patches, global cleanup or security-service changes.
Nightly
.47completed successfully using its original commits, independently of this draft. The owning spec's obsolete pre-launch feed statement is now removed; installed A→B qualification remains separate and required before stable enablement. No installed application was replaced or restarted by this follow-up.