Update to modular skiko - #3435
Open
Hubert Błaszczyk (hub-bla) wants to merge 7 commits into
Open
Update to modular skiko #3435Hubert Błaszczyk (hub-bla) wants to merge 7 commits into
Hubert Błaszczyk (hub-bla) wants to merge 7 commits into
Conversation
Hubert Błaszczyk (hub-bla)
changed the title
Hubert Błaszczyk (hub-bla)
marked this pull request as draft
September 21, 2026 14:49
Comment on lines
89
to
+149
| @@ -131,7 +132,7 @@ internal fun Project.configureDependencyVerification() { | |||
| .map { project.configurations.getByName(it) } | |||
| .flatMap { configuration -> | |||
| configuration.allDependencies.asSequence() | |||
| .filter { it.group != null && it.version != null } | |||
| .filter { it.group?.startsWith("androidx.") == true && it.version != null } | |||
| .map { dependency -> | |||
| AndroidXDependency( | |||
| dependency.group!!, | |||
| @@ -143,7 +144,9 @@ internal fun Project.configureDependencyVerification() { | |||
| .plus( | |||
| configuration.allDependencyConstraints | |||
| .asSequence() | |||
| .filter { it.version != null } | |||
| .filter { | |||
| it.group.startsWith("androidx.") && it.version != null | |||
| } | |||
There was a problem hiding this comment.
Just to make it work with the teamcity snapshot version. To be reverted
| paparazziNative = "2022.1.1-canary-f5f9f71" | ||
| shadow = "8.1.1" | ||
| skiko = "0.152.0-alpha04" | ||
| skiko = "0.0.1-ganesh-module-3-SNAPSHOT" |
There was a problem hiding this comment.
Needs update once skiko is released
Hubert Błaszczyk (hub-bla)
added this pull request to stack #3470
September 30, 2026 10:15
Hubert Błaszczyk (hub-bla)
marked this pull request as ready for review
September 30, 2026 10:16
Hubert Błaszczyk (hub-bla)
force-pushed
the
hub.bla/modular-skiko
branch
from
September 30, 2026 11:15
b9bf940 to
8a861d0
Compare
Hubert Błaszczyk (hub-bla)
force-pushed
the
hub.bla/modular-skiko
branch
from
October 1, 2026 06:47
7e0a04f to
9b5e9a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
N/A