Added offset settling mechanism to OffsetToFocusedRect - #3406
Merged
Vladimir Mazunin (mazunin-v-jb) merged 1 commit intoSep 10, 2026
Merged
Vladimir Mazunin (mazunin-v-jb) merged 1 commit into
Vladimir Mazunin (mazunin-v-jb) merged 1 commit into
Conversation
Refined offset calculation logic to prevent indefinite recalculations during layout changes.
Vladimir Mazunin (mazunin-v-jb)
requested review from
Andrei Salavei (ASalavei) and
Vendula Švastalová (svastven)
September 10, 2026 08:05
|
Is it possible to add a test for the regression? |
Author
|
Not here, but I'm adding it right now in the follow-up PR. There is another bug which doesn't allow adding it here |
Vladimir Mazunin (mazunin-v-jb)
added this pull request to stack #3408
September 10, 2026 09:00
Vladimir Mazunin (mazunin-v-jb)
removed this pull request from stack #3408
September 10, 2026 09:01
Vendula Švastalová (svastven)
approved these changes
Sep 10, 2026
Andrei Salavei (ASalavei)
approved these changes
Sep 10, 2026
Vladimir Mazunin (mazunin-v-jb)
deleted the
v.mazunin/cmp-10727-app-freeze-after-textfields-rotate
branch
September 10, 2026 12:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refined offset calculation logic to prevent indefinite recalculations during layout changes.
Fixes: CMP-10727 [iOS] TextFields. App freezes after rotation with TextFields shifting
Testing
Manual + instrumented test (added here)
Release Notes
Fixes - iOS
(prerelease fix) Fix the app freeze after tapping a text field and rotating the device