Supported bullets drawing in AnnotatedString - #3400
Open
Vladimir Mazunin (mazunin-v-jb) wants to merge 3 commits into
Open
Vladimir Mazunin (mazunin-v-jb) wants to merge 3 commits into
Vladimir Mazunin (mazunin-v-jb) wants to merge 3 commits into
Conversation
- Implemented `SkikoBulletPainter` for rendering bullet markers in paragraphs - Updated `SkikoParagraphBuilder` and `ParagraphLayouter` to process and layout bullets - Adjusted Skia intrinsic width calculations to include bullet indentation - Added utility functions for bullet size resolution and filtering bullet annotations
Vladimir Mazunin (mazunin-v-jb)
requested review from
Ivan Matkov (MatkovIvan)
and removed request for
Ivan Matkov (MatkovIvan)
September 8, 2026 13:26
Vladimir Mazunin (mazunin-v-jb)
marked this pull request as draft
September 8, 2026 13:26
… text layout - Added tests validating proper inclusion of `TextIndent` in max intrinsic width calculations - Ensured proper text layout without wrapping at maximum intrinsic width with indentation - Introduced bullet painting test cases for desktop with color, size, and position validation - Verified correct bullet rendering in indented paragraphs
Vladimir Mazunin (mazunin-v-jb)
marked this pull request as ready for review
September 8, 2026 17:01
Vladimir Mazunin (mazunin-v-jb)
requested a review
from Ivan Matkov (MatkovIvan)
September 8, 2026 17:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Bullet annotation rendering in Skiko text layout
SkikoBulletPainterfor rendering bullet markers in paragraphsSkikoParagraphBuilderandParagraphLayouterto process and layout bulletsFixes: CMP-7151 Support Paragraph(Intrinsics) with annotations
Testing
Should be tested by QA
Release Notes
Features - Multiple Platforms
Fixes - Multiple Platforms