Skip to content

fix: Use FontSynthesis.All as the default in toSkTextStyle (nonAndroid target) - #3399

Open
adamglin0 (adamglin0) wants to merge 1 commit into
JetBrains:jb-mainfrom
adamglin0:fix/skia-text-style-font-synthesis-default
Open

fix: Use FontSynthesis.All as the default in toSkTextStyle (nonAndroid target)#3399
adamglin0 (adamglin0) wants to merge 1 commit into
JetBrains:jb-mainfrom
adamglin0:fix/skia-text-style-font-synthesis-default

Conversation

@adamglin0

@adamglin0 adamglin0 (adamglin0) commented Sep 8, 2026

Copy link
Copy Markdown

toSkTextStyle fell back to FontSynthesis.None when the style had no fontSynthesis, while the StyleAdd pre-resolve and resolveFontFamily paths fell back to FontSynthesis.All. The mismatch produced two different TypefaceRequest keys for the same style and fragmented the font resolver cache. Align on All, which is also the Android default.

Describe proposed changes and the issue being fixed

Testing

(Optional) Describe how you tested your changes (provide a snippet or/and steps)

(Optional) This should be tested by QA

Release Notes

Section - Subsection

Google CLA

Sign the Google Contributor's License Agreement at https://cla.developers.google.com to let us upstream your code to Google's AOSP repository

toSkTextStyle fell back to FontSynthesis.None when the style had no
fontSynthesis, while the StyleAdd pre-resolve and resolveFontFamily
paths fell back to FontSynthesis.All. The mismatch produced two
different TypefaceRequest keys for the same style and fragmented the
font resolver cache. Align on All, which is also the Android default.
@mazunin-v-jb

Copy link
Copy Markdown

Hi!
Could you please clean up the PR description and add the Release Notes?
For Testing it's fine to use something like "N/A since there are no testable changes"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants