Skip to content

GitHub CI. Run only relative platforms changes - #3395

Open
Igor Demin (igordmn) wants to merge 4 commits into
jb-mainfrom
air/igor.demin/disable-windows-tests-47ac2a35-dc4a-4e21-a9ff-7929ba451005
Open

GitHub CI. Run only relative platforms changes#3395
Igor Demin (igordmn) wants to merge 4 commits into
jb-mainfrom
air/igor.demin/disable-windows-tests-47ac2a35-dc4a-4e21-a9ff-7929ba451005

Conversation

@igordmn

@igordmn Igor Demin (igordmn) commented Sep 7, 2026

Copy link
Copy Markdown

Run only Desktop/iOS/Web if only their source sets changed, otherwise run everything.

Reasons:

  • reduce time and flakiness of platform-only changes
  • don't block other PRs if another platform is broken

The full set of changes is still run after merging.

Testing

  • created igor.demin/jb-main-base-tests-for-workflow-changes, changed the PR base
  • changed desktopMain -> skipped iOS/Web checks
  • changed top-level file -> run all checks

Release Notes

N/A

@igordmn Igor Demin (igordmn) changed the title Air/igor.demin/disable windows tests 47ac2a35 dc4a 4e21 a9ff 7929ba451005 GitHub CI. Run only relative platforms changes Sep 7, 2026
@igordmn
Igor Demin (igordmn) force-pushed the air/igor.demin/disable-windows-tests-47ac2a35-dc4a-4e21-a9ff-7929ba451005 branch 8 times, most recently from 5ed255a to 54d805c Compare September 7, 2026 19:35
@igordmn
Igor Demin (igordmn) changed the base branch from jb-main to igor.demin/jb-main-base-tests-for-workflow-changes September 7, 2026 20:22
@igordmn
Igor Demin (igordmn) changed the base branch from igor.demin/jb-main-base-tests-for-workflow-changes to jb-main September 7, 2026 20:24
@igordmn
Igor Demin (igordmn) force-pushed the air/igor.demin/disable-windows-tests-47ac2a35-dc4a-4e21-a9ff-7929ba451005 branch from febfb62 to 54d805c Compare September 7, 2026 20:40
Comment thread .github/path-filter.yml Outdated
- '.github/path-filter.yml'

# Change with sourceSetsUnknown
sourceSetsIos:

@igordmn Igor Demin (igordmn) Sep 8, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea of this PR is to run only iOS/Desktop/Web related workflows if we change only these folders, and run all the tests if change something else.

Ivan Matkov (@MatkovIvan), Alexander Maryanovsky (@m-sasha), Oleksandr Karpovich (@eymar), Andrei Salavei (@ASalavei), does it sound good to you?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great to me!

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked you all to review. Ivan - the logic, the rest of you - the source set list

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the source set list

And the related platform workflow changes

@igordmn
Igor Demin (igordmn) marked this pull request as ready for review September 8, 2026 10:26
Comment thread .github/path-filter.yml
- '**/tvosTest/**'
- '**/watchosMain/**'
- '**/watchosTest/**'
- '**/linuxMain/**'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these 4 sources sets here?

@igordmn Igor Demin (igordmn) Sep 8, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have these source sets, or at least we had and can have in the future.

I renamed it to "...Native"

Comment thread .github/path-filter.yml Outdated
- '**/darwinTest/**'
- '**/nativeMain/**'
- '**/nativeTest/**'
- '**/uikitMain/**'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these 2 are legacy - I would remove them

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@igordmn
Igor Demin (igordmn) force-pushed the air/igor.demin/disable-windows-tests-47ac2a35-dc4a-4e21-a9ff-7929ba451005 branch from 9fc36f5 to 6cb8b4d Compare September 8, 2026 11:48
@igordmn
Igor Demin (igordmn) force-pushed the air/igor.demin/disable-windows-tests-47ac2a35-dc4a-4e21-a9ff-7929ba451005 branch from 09051eb to 99ade3d Compare September 8, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants