Fix portable Swift runtime linking in UIKit klibs - #3274
Open
Vendula Švastalová (svastven) wants to merge 3 commits into
Open
Vendula Švastalová (svastven) wants to merge 3 commits into
Vendula Švastalová (svastven) wants to merge 3 commits into
Conversation
Vendula Švastalová (svastven)
force-pushed
the
svastven/ui-uikit-gradle-fix
branch
5 times, most recently
from
August 1, 2026 13:32
251b219 to
3f54ee6
Compare
Vendula Švastalová (svastven)
marked this pull request as ready for review
August 3, 2026 11:22
Vendula Švastalová (svastven)
requested review from
Ivan Matkov (MatkovIvan) and
Konstantin (terrakok)
August 3, 2026 11:23
Hubert Błaszczyk (hub-bla)
self-requested a review
August 27, 2026 13:14
| } | ||
| } | ||
|
|
||
| private fun KotlinNativeTarget.configureSwiftCompatibilityLinking() { |
There was a problem hiding this comment.
Can we add a comment that explain the purpose of it?
My understanding so far is that Kotlin/Native doesn't know about this folder when linking. Because of that we are forced to create this logic not only in cmp-core but also inside our compose plugin.
Ideally, Kotlin/Native could take care of this automatically, since it already resolves the path to the linker from the toolchain.
https://youtrack.jetbrains.com/issue/KT-69793 seems related. Maybe we can ask the Kotlin/Native team to add it?
Vendula Švastalová (svastven)
force-pushed
the
svastven/ui-uikit-gradle-fix
branch
from
September 14, 2026 16:44
3f54ee6 to
ed2fca0
Compare
Konstantin (terrakok)
approved these changes
Sep 15, 2026
Konstantin (terrakok)
left a comment
Konstantin (terrakok)
left a comment
Member
There was a problem hiding this comment.
From a gradle code perspective the PR seems good. Regarding linker flags I don't have a proper knowledge
This comment was marked as spam.
This comment was marked as spam.
2 similar comments
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Vendula Švastalová (svastven)
force-pushed
the
svastven/ui-uikit-gradle-fix
branch
from
September 17, 2026 16:41
ed2fca0 to
384966f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid publishing Xcode path in the UIKit swiftUtils KLib metadata.
The Swift runtime library names remain portable linker requirements in
swiftUtils.def. And the active Xcode toolchain's Swift compatibility library directory is resolved lazily at final iOS link time.Fixes CMP-10607 Resolve Swift compatibility libraries from the consumer’s active Xcode during iOS linking
Release Notes
N/A