Skip to content

Remove ComposeUiFlags.areWindowInsetsRulersEnabled - #3211

Merged
Vendula Švastalová (svastven) merged 8 commits into
jb-mainfrom
svastven/CMP-9823
Sep 17, 2026
Merged

Vendula Švastalová (svastven) merged 8 commits into
jb-mainfrom
svastven/CMP-9823

Conversation

@svastven

@svastven Vendula Švastalová (svastven) commented Jul 10, 2026 •

Copy link
Copy Markdown

Removes ComposeUiFlags.areWindowInsetsRulersEnabled in favor of common WindowInsetsRulers.disable()

Fixes CMP-9823 Consider removing ComposeUiFlags.areWindowInsetsRulersEnabled flag

Prerequisity of merging this PR is that AOSP changes in the CL are merged and then synced into the fork. ✅

Testing

  • UIKit instrumented tests: adds testDisableWindowInsetsRulers to WindowInsetsRulersTest
  • skiko: adds DisableWindowInsetsRulersTest test suite

Release Notes

Features - Multiple Platforms

  • Remove ComposeUiFlags.areWindowInsetsRulersEnabled in favor of WindowInsetsRulers.disable()

@eymar

Oleksandr Karpovich (eymar) commented Sep 17, 2026 •

Copy link
Copy Markdown
Member

I see the test failed: androidx.compose.ui.layout.DisableWindowInsetsRulersTest.disableWindowInsetsRulers[iosSimulatorArm64] FAILED

Probably the value is read earlier than setContent.

For web it's fine to have such a setup:

@Test
fun testSomething(): TestResult {
    disableFeature()
    
    return runTest {
        // test block 
    }
}

I expect it will work fine for all other platforms too.

@svastven
Vendula Švastalová (svastven) merged commit 9c1c04c into jb-main Sep 17, 2026
23 checks passed
@svastven
Vendula Švastalová (svastven) deleted the svastven/CMP-9823 branch September 17, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants