Remove ComposeUiFlags.areWindowInsetsRulersEnabled - #3211
Merged
Merged
Conversation
… disableWindowInsetsRulers
Vendula Švastalová (svastven)
requested review from
Andrei Salavei (ASalavei),
Ivan Matkov (MatkovIvan) and
Oleksandr Karpovich (eymar)
July 10, 2026 13:21
Ivan Matkov (MatkovIvan)
requested changes
Jul 10, 2026
Vendula Švastalová (svastven)
requested a review
from Ivan Matkov (MatkovIvan)
September 16, 2026 10:56
Ivan Matkov (MatkovIvan)
approved these changes
Sep 16, 2026
Andrei Salavei (ASalavei)
approved these changes
Sep 17, 2026
Vendula Švastalová (svastven)
requested a review
from Oleksandr Karpovich (eymar)
September 17, 2026 09:34
Vendula Švastalová (svastven)
force-pushed
the
svastven/CMP-9823
branch
from
September 17, 2026 09:36
24c393a to
f4e2b21
Compare
Oleksandr Karpovich (eymar)
approved these changes
Sep 17, 2026
Member
|
I see the test failed: androidx.compose.ui.layout.DisableWindowInsetsRulersTest.disableWindowInsetsRulers[iosSimulatorArm64] FAILED Probably the value is read earlier than setContent. For web it's fine to have such a setup: @Test
fun testSomething(): TestResult {
disableFeature()
return runTest {
// test block
}
}I expect it will work fine for all other platforms too. |
This reverts commit f4e2b21.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
ComposeUiFlags.areWindowInsetsRulersEnabledin favor of commonWindowInsetsRulers.disable()Fixes CMP-9823 Consider removing ComposeUiFlags.areWindowInsetsRulersEnabled flag
Prerequisity of merging this PR is that AOSP changes in the CL are merged and then synced into the fork. ✅
Testing
testDisableWindowInsetsRulerstoWindowInsetsRulersTestDisableWindowInsetsRulersTesttest suiteRelease Notes
Features - Multiple Platforms
ComposeUiFlags.areWindowInsetsRulersEnabledin favor ofWindowInsetsRulers.disable()