fix: indexing issue between DECAYS::Particle and REC::VertDoca bank#1212
Open
skuditha wants to merge 1 commit intoJeffersonLab:developmentfrom
Open
fix: indexing issue between DECAYS::Particle and REC::VertDoca bank#1212skuditha wants to merge 1 commit intoJeffersonLab:developmentfrom
skuditha wants to merge 1 commit intoJeffersonLab:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix off-by-one mismatch in
REC::VertDocamatching for decay reconstruction.The decay code was comparing
p1.getIdx()-1/p2.getIdx()-1toREC::VertDoca.index1/index2, which caused valid charged-particle pairs to miss the vertex-bank match and be dropped fromDECAYS::Particle.This PR removes the unnecessary
-1offset in the four affected comparisons so thatREC::Particleindices are matched correctly toREC::VertDoca. This restores missing valid decay candidates without changing the reconstruction logic otherwise.