Repository navigation
Add back plain-HTTP marimo/marimo-podman runnables, for testing - #24
Merged
Merged
Conversation
Re-adds Fileglancer-launchable plain-HTTP jobs (removed in 98ea8d8) alongside the existing HTTPS-only ones, now compatible with Fileglancer's per-job HTTPS proxy (JaneliaSciComp/fileglancer#440): once a deployment sets apps.service_proxy_domain, these jobs' published links are fetched over HTTPS end-to-end through Fileglancer's nginx proxy even though Marimo itself only ever speaks plain HTTP on the compute node. Unlike the removed runnables, these pass no --token-password flag at all -- FG_SERVICE_TOKEN is already forwarded into the container's environment, and entrypoint.sh resolves it from there on its own. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
marimo/marimo-podmanFileglancer runnables (plain HTTP, no local Caddy/TLS layer) that were removed in 98ea8d8, for testing purposes.apps.service_proxy_domain, these jobs' published links are fetched over HTTPS end-to-end via Fileglancer's nginx proxy, even though Marimo itself only ever speaks plain HTTP on the compute node. Without that setting, the link is plain HTTP like before.--token-password "$FG_SERVICE_TOKEN"directly on the command line), these pass no token flag at all —FG_SERVICE_TOKENis already forwarded into the container's environment (common.sh'sENV_PAIRSallowlist), andcontainer/entrypoint.shresolves it from there.This PR is based on
main, which does not yet include theentrypoint.shfix from #23 (--token-password-fileinstead of--token-passwordon argv). Onmaintoday,entrypoint.sh'sFG_SERVICE_TOKENfallback still puts the token onmarimo's command line — verified live: withmain'sentrypoint.sh, this reintroduces the exact argv-exposure issue #23 fixes. With #23'sentrypoint.shbind-mounted in for testing, the same command produces no token on any process's argv.Recommendation: merge #23 before this PR (or merge this after #23, whichever lands first) so these runnables ship secure from the start. I did not rebase this branch onto #23's branch since it was requested off
main, but happy to do so if preferred.Test plan
runnables.yamlparses as valid YAML with the expected 4 runnable ids (marimo,marimo-podman,marimo-https,marimo-podman-https)marimorunnable's exact command (pixi run marimo-apptainer --port ...withFG_SERVICE_TOKENset, no token flag) against the current image: confirmed marimo starts and enforces the tokenmarimo's argv withmain's currententrypoint.sh(expected, until Stop exposing service tokens via process command-line arguments #23 merges) and does not appear with Stop exposing service tokens via process command-line arguments #23's fixedentrypoint.shbind-mounted in🤖 Generated with Claude Code