Repository navigation
feat(views): open the Sources tab from the viewer toolbar - #479
Open
allison-truhlar wants to merge 2 commits into
Open
allison-truhlar wants to merge 2 commits into
allison-truhlar wants to merge 2 commits into
Conversation
The new info button opens the sidebar straight to the Sources tab, so the toolbar now picks which tab the sidebar opens on.
allison-truhlar
force-pushed
the
views-info-button
branch
from
October 21, 2026 19:38
080f8d3 to
26c0e03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #477.
What changed
The viewer toolbar now has an info button ("View and edit data sources") that opens the sidebar on the Sources tab. The existing "Add data" button still opens it on the Add tab.
Pressing either button while its tab is showing closes the sidebar. Pressing the other button switches tabs and keeps the sidebar open.
NeuroglancerViewnow decides which tab the sidebar shows.ViewerSidebarreceivestabandonTabChangeinstead of keeping its own tab state.Testing
A new test in
NeuroglancerView.test.tsxchecks that the info button opens the Sources tab, that its pressed state is shown, and that a second press closes the sidebar.Clickup id: 17tkuw5z7wa
@krokicki