Skip to content

Handle repeated channel names in the Layer Cart and Sources - #475

Open
allison-truhlar wants to merge 5 commits into
mainfrom
fix-duplicate-channel-names
Open

allison-truhlar wants to merge 5 commits into
mainfrom
fix-duplicate-channel-names

Conversation

@allison-truhlar

@allison-truhlar allison-truhlar commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

What changed

  • The Layer Cart tracks a channel by its position in the dataset instead
    of its name. Checking one Gpb5 round no longer checks every Gpb5.
  • Channels that share a label get unique Neuroglancer layer names
    (Gpb5, Gpb5 (2), Gpb5 (3)), so every selected round loads.
    Checkout also renames layers that collide across datasets, such as two
    datasets that each have DAPI.
  • Long channel lists in the Layer Cart and the Sources tab wrap into
    columns when the panel is wide enough.
  • The Sources tab lists every channel of a dataset added channel by
    channel, with the channels in the View checked. Checking an unlisted
    channel adds it as a shown layer.

Why

A dataset with repeated probe rounds showed one set of channels checked
in the cart and loaded a different set in Neuroglancer. Adding another
channel from a dataset already in the View also meant a trip back to the
Add data tab.

Testing

  • Frontend unit tests pass (pixi run test-frontend), including new
    tests for repeated channel names, cross-dataset layer names, the full
    channel list in Sources, and the "Added 1 channel" toast.
  • ESLint is clean. pixi run node-check reports only the 6 errors
    already on main.

@krokicki
Clickup id: 17tkuw5z7va

Datasets can repeat a channel label, so name-keyed entries made one
checkbox toggle every channel that shared the label.
Neuroglancer needs unique layer names, so channels that shared a label
loaded as a single layer.
Two datasets in one View can share a layer name, such as DAPI, and
Neuroglancer drops one of them.
Datasets with dozens of channels made the Layer Cart a single long column.
Sources listed only the channels already in the View, so adding another
channel from the same dataset meant a trip back to the Add data tab.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant