Repository navigation
Handle repeated channel names in the Layer Cart and Sources - #475
Open
allison-truhlar wants to merge 5 commits into
Open
allison-truhlar wants to merge 5 commits into
allison-truhlar wants to merge 5 commits into
Conversation
Datasets can repeat a channel label, so name-keyed entries made one checkbox toggle every channel that shared the label.
Neuroglancer needs unique layer names, so channels that shared a label loaded as a single layer.
Two datasets in one View can share a layer name, such as DAPI, and Neuroglancer drops one of them.
Datasets with dozens of channels made the Layer Cart a single long column.
Sources listed only the channels already in the View, so adding another channel from the same dataset meant a trip back to the Add data tab.
allison-truhlar
added this pull request to stack #478
October 21, 2026 19:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
of its name. Checking one
Gpb5round no longer checks everyGpb5.(
Gpb5,Gpb5 (2),Gpb5 (3)), so every selected round loads.Checkout also renames layers that collide across datasets, such as two
datasets that each have
DAPI.columns when the panel is wide enough.
channel, with the channels in the View checked. Checking an unlisted
channel adds it as a shown layer.
Why
A dataset with repeated probe rounds showed one set of channels checked
in the cart and loaded a different set in Neuroglancer. Adding another
channel from a dataset already in the View also meant a trip back to the
Add data tab.
Testing
pixi run test-frontend), including newtests for repeated channel names, cross-dataset layer names, the full
channel list in Sources, and the "Added 1 channel" toast.
pixi run node-checkreports only the 6 errorsalready on
main.@krokicki
Clickup id: 17tkuw5z7va