Skip to content

Let metadata model be a list of models - #11

Merged
cmalinmayor merged 2 commits into
refactor-sample-and-reprfrom
disc_union_metadata
Oct 20, 2026
Merged

cmalinmayor merged 2 commits into
refactor-sample-and-reprfrom
disc_union_metadata

Conversation

@cmalinmayor

Copy link
Copy Markdown
Collaborator

Proposed Change

Let user pass in multiple metadata models, and combine them in a discriminative union

Checklist

Go through these things before merge. Actions should run automatically to test them, but for information on how to run locally, see CONTRIBUTING.md.

  • I have added tests that prove that my feature works in various situations or tests the bugfix (if applicable).
  • I have checked that the tests pass and I maintained or improved test coverage (just test-cov).
  • I have written docstrings for any new public functions and classes.
  • I have checked that linting and formatting pass (just lint).
  • I have checked that mypy type checking passes (just typecheck).

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@cmalinmayor
cmalinmayor added this pull request to stack #12 October 20, 2026 00:33
@cmalinmayor
cmalinmayor merged commit 53c853a into main Oct 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant