Bump actions/checkout from 3 to 4 - #8
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Jamiras
pushed a commit
that referenced
this pull request
Aug 30, 2026
A successful overlay load hands the overlays, the overlay path and
the image list to the consumer through overlay_task_data_t, and the
task queue retires a task by running its callback and then its
cleanup. So input_overlay_loaded() releases the image list first,
and task_overlay_free() released it again straight after:
Abort message: 'Scudo ERROR: invalid chunk state when
deallocating address 0x200006d36fbb9c0'
#5 string_list_free+84
#6 task_overlay_free
#7 retro_task_internal_retire_cleanup
#8 rarch_main
Every successful overlay load aborts, which on Android means every
startup that brings up the touch overlay, and thereafter every
overlay switch and every content load.
The release was made unconditional to plug what looked like a leak
of the list container on the success path. It is not one - the
consumer frees it, on both of its paths (input/input_driver.c) -
so the conditional it replaced was right about the list. What the
old condition did get wrong is that RETRO_TASK_FLG_CANCELLED is not
what decides whether the loader still owns anything: a load that
finishes but cannot allocate its overlay_task_data_t returns
without handing off, and the cleanup then walked away from the
overlays, the path, the list and every texture in it.
Drop the loader's references as the hand-off takes them, and key
the cleanup on the pointers instead of on the flag. A pointer
still set is one nobody took, whichever way the load ended, so both
the second release and the missed one go away.
The oracle could not see this: its stub consumer took the overlays
and the path but left the image list alone, so the loader's release
was the only one in the run. Make it take the list too, the way
the real consumer does.
ASan+UBSan+LSan and TSan clean over samples/tasks/overlay; with the
oracle corrected and the fix reverted, ASan reports the
use-after-free above at task_overlay.c:1299.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/checkout from 3 to 4.
Release notes
Sourced from actions/checkout's releases.
... (truncated)
Changelog
Sourced from actions/checkout's changelog.
... (truncated)
Commits
3df4ab1Release 4.0.0 (#1447)8b5e8b7Support fetching without the --progress option (#1067)97a652bUpdate default runtime to node20 (#1436)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)