Open
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Pull Request Description
Please fill out each section below.
The goal is that reviewers can understand everything without reading the code.
🧩 What was changed?
Overwrote the default (from @Setter annotation) opening hours setter to enable proper removal and addition of new/updated opening hours.
💡 Why was it changed?
Previous version caused bugs when trying to update different opening hours per different day (what JUCanEat/react-frontend#115 is adding in UI).
⚙️ How was it implemented?
Simple change from default setter to one with safe delete before any opening hours update update, keeping the list intact.
None that I am aware of, besides frontend working properly:)
✅ Checklist