fix(review): demote AI review nits into the collapsible Nits section, not the headline#1577
Merged
Merged
Conversation
… not the headline The composed advisory notes baked the AI's `**Nits (N)**` bullets straight into the prominent assessment blob, so non-blocking nits read like top-line findings. Split them out (splitAiReviewNits): the assessment keeps the prose + any `**Blockers**` (real problems stay headline), and the AI nits fold into the SAME collapsible Nits section as the gate warnings. Nits are never blockers.
dosubot
Bot
added
the
size:M
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1577 +/- ##
=======================================
Coverage 95.45% 95.45%
=======================================
Files 202 202
Lines 21766 21776 +10
Branches 7864 7865 +1
=======================================
+ Hits 20776 20786 +10
Misses 414 414
Partials 576 576
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The composed advisory notes baked the AI's
**Nits (N)**bullets into the prominent assessment blob, so non-blocking nits rendered like top-line findings.splitAiReviewNitsnow peels the trailing nits off the notes — the assessment keeps the prose + any**Blockers**(real problems stay headline), and the AI nits fold into the same collapsible Nits section as the gate warnings. Nits are never blockers.