fix(review): enforce inline comment gates#1548
Merged
JSONbored merged 2 commits intoJun 27, 2026
Merged
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1548 +/- ##
=======================================
Coverage 95.38% 95.38%
=======================================
Files 201 201
Lines 21598 21601 +3
Branches 7807 7809 +2
=======================================
+ Hits 20601 20604 +3
Misses 416 416
Partials 581 581
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review — held for maintainer review
⏸️ Held for maintainer review
Nits — 2 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
inlineFindingsfrom causing unauthorized GitHub writes when the inline-comments feature is disabled by the operator flag, repo allowlist, or per-repo manifest toggle.Description
runGittensoryAiReviewto returninlineFindingsonly wheninput.inlineFindingsis truthy (stop propagating unexpected AI output). (src/services/ai-review.ts)inlineCommentsEnabledparameter to the write boundary and makemaybePostInlineCommentsreturn early when disabled, avoiding loading PR files or calling GitHub. (src/review/inline-comments.ts)src/queue/processors.ts)test/unit/ai-review.test.ts,test/unit/inline-comments.test.ts)Testing
npx vitest run test/unit/inline-comments.test.ts test/unit/ai-review.test.ts --reporter=verbose, and all tests in those files passed.tsc --noEmitvianpm run typecheck, which succeeded with no type errors.git diff --checkreturned clean.npm run test:coverage; the run was initiated but did not complete in this environment before the job was terminated.npm audit --audit-level=moderatecould not complete due to the registry audit endpoint returning403 Forbiddenin this environment.Codex Task