fix(db): scrub /root/ and /var/ paths from product-usage metadata#1459
Open
kiannidev wants to merge 1 commit into
Open
fix(db): scrub /root/ and /var/ paths from product-usage metadata#1459kiannidev wants to merge 1 commit into
kiannidev wants to merge 1 commit into
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1459 +/- ##
=======================================
Coverage 95.38% 95.38%
=======================================
Files 201 201
Lines 21598 21598
Branches 7807 7807
=======================================
Hits 20601 20601
Misses 416 416
Partials 581 581
🚀 New features to boost your workflow:
|
Extend the product-usage local-path redactor so telemetry metadata cannot persist /root/ or /var/ absolute paths in D1. Co-authored-by: Cursor <cursoragent@cursor.com>
4a997d1 to
e7d9bf1
Compare
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ Gittensory review — safe to merge
✅ Approved — safe to merge
Nits — 2 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PRODUCT_USAGE_LOCAL_PATHinrepositories.tsto redact/root/and/var/absolute paths before product-usage events are persisted./root/already redacted elsewhere;/var/was missing here).Related: #1418 (single-surface slice)
Test plan
npx vitest run test/unit/product-usage.test.ts -t "redacts sensitive metadata"/root/work/...and/var/log/...paths; persisted JSON must not contain them