Clarify single-line comment behavior in documentation#24
Open
chirsz-ever wants to merge 1 commit intoJSONC-org:mainfrom
Open
Clarify single-line comment behavior in documentation#24chirsz-ever wants to merge 1 commit intoJSONC-org:mainfrom
chirsz-ever wants to merge 1 commit intoJSONC-org:mainfrom
Conversation
Member
|
I think the current wording is already clear enough. The comment still continues until a line ending is reached, it's just that when comment is at the end of the file with no EOL at the end, we stop at EOF while we are still inside the comment. |
Member
|
I think a better option would be:
Thoughts? |
Contributor
Author
|
I'm glad we're on the same page. The PR has been revised to match your wording. With the ABNF description, the importance of natural language description is reduced; it's OK to edit or close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to ECMA-262, a single-line comment consists of
//followed by characters which are not line terminators.Therefore, a line comment can be placed at the end of a file, string, or input without being followed by a newline character.