Explicitly state the qt package is not buildable when externals are provided#2023
Draft
jim-p-w wants to merge 1 commit into
Draft
Explicitly state the qt package is not buildable when externals are provided#2023jim-p-w wants to merge 1 commit into
jim-p-w wants to merge 1 commit into
Conversation
…rovided. For all tier1 sites which define where qt can be found externally, add the buildable:false attribute. Note this is already specified in most site specific package files.
climbfuji
reviewed
May 21, 2026
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
@jim-p-w Thanks for this! Looks correct to me. Regarding Acorn and WCOSS2, I believe a similar change is needed for the Intel Classic compilers. But we can discuss this at the next framework meeting in 2.5 weeks (please remind me) with @AlexanderRichert-NOAA. That chance can be made in a follow-up PR.
I am surprised that none of the other tier-1 site configs has qt configured as an external package - the respective site maintainers will have to check on those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For all tier1 sites which define where qt can be found externally, add the
buildable:falseattribute.Note this is already specified in most site1 specific package files.
There are two remaining site1 specific packages specs which contain specs for qt:
acorn
configs/sites/tier1/acorn/packages_intel-19.1.3.304.yamlandwcoss2
configs/sites/tier1/wcoss2/packages_intel-19.1.3.304.yamlThese are for the intel compiler so should not be impacted.
Neither the packages.yaml or the packages_oneapi *.yaml files in acorn and wcoss2 have any specs for qt.
Description
There had been a conflict between the spec for the qt package in
configs/common/packages_oneapi.yamland some site specific config files, e.g.configs/sites/tier1/derecho/packages.yamlThis issue was exposed when ecflow was added as required for the derecho, hercules and orion sites in PR #1989
This issue was partially resolved when PR #2011 removed the qt specification from
configs/common/packages_oneapi.yamlDependencies
None.
Issues addressed
None
Applications affected
???
Systems affected
Potentially hera, hercules, orion
Testing
I do not have access to any of the potentially impacted systems, so my testing has been limited to creating environments for hera, hercules, and orion, and subsequently concretizing those environments All that was done on the derecho system.
The concretize step succeeded for the hercules and orion environments.
The concretize step failed for the hera environment, but apparently for reason(s) unrelated to this PR:
Checklist