Skip to content

Update TEC Test Data and PathSum Inputs to SI Units - #608

Merged
BenjaminRuston merged 12 commits into
developfrom
feature/hs-unitchange
Nov 2, 2026
Merged

BenjaminRuston merged 12 commits into
developfrom
feature/hs-unitchange

Conversation

@huishao-r

@huishao-r huishao-r commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Update the PathSum TEC test configuration (and associated test data in ufo-data repo) to use SI units consistently. This includes YAML configurations, reference observations, and variable naming to better follow CF conventions.

Changes include:

Updated GeoVaLs files (ufo-data)
electron density from cm⁻³ to m⁻³
height-related quantities from km to m
Removed unused fields from some of the testing files (ufo-data)
Updated new reference values (better precision) (ufo-data, yaml)
Renamed height_wrt_height to height_above_reference_ellipsoid to follow CF conventions. (ufo-data, yaml)

Issue(s) addressed

Resolves #609
build-group=https://github.com/JCSDA-internal/ufo/pull/4428

Dependencies

These data are used by https://github.com/JCSDA-internal/ufo/pull/4428

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@huishao-r huishao-r self-assigned this Oct 20, 2026
@huishao-r huishao-r added the NAVY United States Naval Research Lab label Oct 20, 2026
@BenjaminRuston
BenjaminRuston marked this pull request as ready for review October 28, 2026 21:18
@BenjaminRuston

Copy link
Copy Markdown
Collaborator

this file is almost 6Mb can it be reduced?
testinput_tier_1/geovals_madirgal_slant-tec_202010232345_100locs.nc4

@jhaiduce

Copy link
Copy Markdown

this file is almost 6Mb can it be reduced?

testinput_tier_1/geovals_madirgal_slant-tec_202010232345_100locs.nc4

Should be doable. This file was created by randomly sampling data from a larger source file (which was a couple gigabytes in size of I remember right). Assuming none of the tests this is used in actually require 100 obs we can just use a smaller subset of this data. @huishao-r do you think 5 obs will be enough?

@huishao-r

Copy link
Copy Markdown
Collaborator Author

this file is almost 6Mb can it be reduced?
testinput_tier_1/geovals_madirgal_slant-tec_202010232345_100locs.nc4

Should be doable. This file was created by randomly sampling data from a larger source file (which was a couple gigabytes in size of I remember right). Assuming none of the tests this is used in actually require 100 obs we can just use a smaller subset of this data. @huishao-r do you think 5 obs will be enough?

@BenjaminRuston @jhaiduce I reduced the file size using nccopy. I hope it is ok now.

@huishao-r

Copy link
Copy Markdown
Collaborator Author

this file is almost 6Mb can it be reduced?
testinput_tier_1/geovals_madirgal_slant-tec_202010232345_100locs.nc4

Should be doable. This file was created by randomly sampling data from a larger source file (which was a couple gigabytes in size of I remember right). Assuming none of the tests this is used in actually require 100 obs we can just use a smaller subset of this data. @huishao-r do you think 5 obs will be enough?

@BenjaminRuston @jhaiduce I reduced the file size using nccopy. I hope it is ok now.

@BenjaminRuston I compressed the other two geoval files. Now the sizes are quite small.

@BenjaminRuston BenjaminRuston added the coordinated merge Needs to be coordinated with other repos label Nov 2, 2026
@BenjaminRuston
BenjaminRuston requested a review from fcvdb November 2, 2026 20:17

@fcvdb fcvdb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hui!

@fcvdb
fcvdb requested a review from BenjaminRuston November 2, 2026 21:22

@BenjaminRuston BenjaminRuston left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent thanks for reducing the file size @huishao-r

@BenjaminRuston
BenjaminRuston merged commit e742d3d into develop Nov 2, 2026
2 checks passed
@BenjaminRuston
BenjaminRuston deleted the feature/hs-unitchange branch November 2, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coordinated merge Needs to be coordinated with other repos NAVY United States Naval Research Lab

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update TEC Test Data and PathSum Inputs to SI Units

4 participants