Repository navigation
Conversation
fmahebert
commented
Nov 3, 2026
|
|
||
| State::State(const oops::Variables & vars, const State & other) : State(other) | ||
| { | ||
| // TODO(Travis, maybe) The variable change needs to go here |
guillaumevernieres
approved these changes
Nov 3, 2026
svahl991
approved these changes
Nov 3, 2026
shlyaeva
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OOPS PR https://github.com/JCSDA-internal/oops/pull/3446 removes the
State(Variables, State)constructor, leaving any implementations in the model interfaces as unused code.This PR cleans up the soca constructor and test.
Issue(s) addressed
Toward https://github.com/JCSDA-internal/oops/issues/3445
Dependencies
Merge any time AFTER
build-group=https://github.com/JCSDA-internal/oops/pull/3446
Impact
Checklist