Repository navigation
Adapt to removing inverse variable change interface - #1236
Merged
Merged
Conversation
shlyaeva
marked this pull request as ready for review
April 11, 2026 12:46
guillaumevernieres
approved these changes
Apr 13, 2026
Collaborator
Author
|
@Dooruk do you mind taking a look when you have some time? No functionality changes but this may require change in yaml if you use Jb diagnostics and BalanceSOCA variable change in B (see example in 3dvar.yaml for how to adapt yaml and not have any change in results, or 3dvar_lowres.yaml for how to adapt yaml and have only small change in Jb/J computation -- see reference change for that test) |
Dooruk
approved these changes
Oct 13, 2026
Dooruk
left a comment
Dooruk
left a comment
Collaborator
There was a problem hiding this comment.
I won't have time to test this, busy with churning out results for the CoupledTT conference and reviewing a paper but looks good with minimal changes in SOCA. Just curious if you compared results with a high-res case?
No worries, we can adapt to any YAML changes thrown our way 😎
Dooruk
reviewed
Oct 13, 2026
| !! | ||
| !! - forward: deaggregates a 2D analysis of sea-ice and inserts | ||
| !! analysis in CICE restarts | ||
| !! - inverse: TODO(G), aggregates seaice variables along CICE sea-ice |
4 of 8 tasks
jcsda-bot
pushed a commit
to JCSDA/mpas-jedi
that referenced
this pull request
Oct 23, 2026
TYPE: maintenance DESCRIPTION OF CHANGES: This cleans up mpas-jedi related to removing inverse variable change interface (this change is not essential, it's just a cleanup). Here I removed the inverse interfaces from variable and linear variable changes where applicable (base classes, trait classes and classes where the inverse was not implemented). I have kept inverses in LinVarChaC2A class (since they were implemented) for potential use within mpas-jedi. build-group=JCSDA-internal/oops#3261 build-group=JCSDA-internal/saber#1225 build-group=JCSDA-internal/fv3-jedi#1498 build-group=JCSDA-internal/soca#1236 LIST OF MODIFIED FILES: M src/mpasjedi/LinearVariableChange/Base/LinearVariableChangeBase.h M src/mpasjedi/LinearVariableChange/Control2Analysis/LinVarChaC2A.h M src/mpasjedi/LinearVariableChange/LinearVariableChange.cc M src/mpasjedi/LinearVariableChange/LinearVariableChange.h M src/mpasjedi/LinearVariableChange/Model2GeoVars/LinVarChaModel2GeoVars.cc M src/mpasjedi/LinearVariableChange/Model2GeoVars/LinVarChaModel2GeoVars.h M src/mpasjedi/VariableChange/Base/VariableChangeBase.h M src/mpasjedi/VariableChange/Model2GeoVars/VarChaModel2GeoVars.cc M src/mpasjedi/VariableChange/Model2GeoVars/VarChaModel2GeoVars.h M src/mpasjedi/VariableChange/VariableChange.cc M src/mpasjedi/VariableChange/VariableChange.h TESTS CONDUCTED: built and ran ctests on my mac (orbstack + spack-stack 1.9) --------- Co-authored-by: Steve Vahl <42982505+svahl991@users.noreply.github.com> Co-authored-by: Nate Crossette <ncrossette@ucar.edu> Co-authored-by: Francois Hebert <hebert@ucar.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adapts soca to removing inverse variable change interface:
full inversewhen computing Jb diagnostics in Var that uses linear variable changes (I have removed the option of explicitly calling inverses when using linear variable changes in oops PR). This results in reasonable changes in Jb diagnostic prints.Model2AnaandBalanceclasses (since they were implemented) for potential use within soca.Dependencies
build-group=https://github.com/JCSDA-internal/oops/pull/3261
build-group=https://github.com/JCSDA-internal/saber/pull/1225
build-group=https://github.com/JCSDA-internal/fv3-jedi/pull/1498
build-group=https://github.com/JCSDA-internal/mpas-jedi/pull/1178
Checklist