Skip to content

SDK-412 UUA Naming inconsistencies #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joaodordio wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Draft

SDK-412 UUA Naming inconsistencies #1049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions iterableapi/src/main/java/com/iterable/iterableapi/IterableApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,7 +852,7 @@ public static void initialize(@NonNull Context context, @NonNull String apiKey,
&& sharedInstance.config.enableUnknownUserActivation
&& sharedInstance.getVisitorUsageTracked()) {
sharedInstance.unknownUserManager.updateUnknownSession();
sharedInstance.unknownUserManager.getCriteria();
sharedInstance.unknownUserManager.getUnknownCriteria();
}

if (DeviceInfoUtils.isFireTV(context.getPackageManager())) {
Expand Down Expand Up @@ -1768,7 +1768,7 @@ public void setVisitorUsageTracked(@NonNull Boolean isSetVisitorUsageTracked) {

if (isSetVisitorUsageTracked && config.enableUnknownUserActivation) {
unknownUserManager.updateUnknownSession();
unknownUserManager.getCriteria();
unknownUserManager.getUnknownCriteria();
}
}

Expand Down
6 changes: 3 additions & 3 deletions iterableapi/src/main/java/com/iterable/iterableapi/UnknownUserManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ void trackUnknownUpdateCart(@NonNull List<CommerceItem> items) {
}
}

void getCriteria() {
void getUnknownCriteria() {
lastCriteriaFetch = System.currentTimeMillis();

iterableApi.apiClient.getCriteriaList(data -> {
Expand Down Expand Up @@ -258,7 +258,7 @@ private void handleTrackFailure(JSONObject data) {
try {
int statusCode = (int) data.get(IterableConstants.HTTP_STATUS_CODE);
if (statusCode == 409) {
getCriteria(); // refetch the criteria
getUnknownCriteria(); // refetch the criteria
}
} catch (JSONException e) {
e.printStackTrace();
Expand Down Expand Up @@ -498,7 +498,7 @@ public void onSwitchToForeground() {
&& currentTime - lastCriteriaFetch >= IterableConstants.CRITERIA_FETCHING_COOLDOWN) {

lastCriteriaFetch = currentTime;
this.getCriteria();
this.getUnknownCriteria();
IterableLogger.d(TAG, "Fetching unknown user criteria - Foreground");
}
}
Expand Down
Loading