Fix RX_EN handling during RX power saving - #12
Merged
Conversation
Owner
|
set radio.rxps.rfrx_disabled on => Before fix |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR adds fix for
rx enablepin, previously it was not enabled.Additionally I'm curious if in high interference sites this firmware worked much better for some unknown reason anyway. So I have added cli commands:
get radio.rxps.rfrx_disabled- check if rx_en pin is enabled or disabledset radio.rxps.rfrx_disabled on/off- enable and disable rx_en pin.Default state is "rx_en pin always enabled" - even after restart, these commands are not persisted in memory across restarts. So for testing purposes you can enable repeater auto-restart and enable this commad to see if there is any difference, if the repeater becomes unavailable because it lost it's hearing after restart it will be good again.
Minimal fix for rx_en pin if this whole sheningas with new commands are not welcome:
file
CustomSX1262.h