Repository navigation
merge: de-leak AU OfflineRender / VST3 process-mode fixes into master (product pin union) - #23
Merged
Merged
Conversation
The AU wrapper ignored kAudioUnitProperty_OfflineRender, so an offline bounce in hosts such as Logic still reached the plugin as real-time: AuProcessContext fell back to the trait's `host_render_mode() == None` and BufferConfig.process_mode was hard-coded to Realtime. Support the property on the global scope (GetPropertyInfo/Get/Set as a writable UInt32 stored in an atomic, settable while initialized), feed it into BufferConfig.process_mode for Initialize and ClassInfo restore, and snapshot it once per render block so host_render_mode() follows a change between renders without re-initialisation, as the VST3 and CLAP wrappers already do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Intrect shared-stack P0: one fork rev for every product.
Today de-artifact pins
bd819ab(already in master) and de-leak-rt pins91266c6, which master lacks. Neither has the other's fixes:91266c62(reportkAudioUnitProperty_OfflineRenderas the process mode) andf68c86bd(forward current VST3 setup/callback process modes).1152dc72,bd819abf) and the AUD-2067 lifecycle serialization.This merges
91266c6into master. One conflict insrc/wrapper/vst3/wrapper.rs: both sides added a helper afterWrapper::new(clear_process_outputsfrom AUD-2067,process_mode_from_hostfrom f68c86b) — both kept, no logic change.Verification
cargo test --lib --features "vst3 au standalone": 161 passed (incl. the newsetup_processing_tests).cargo fmt --checkclean.pinned/*until those pass.