Repository navigation
fix(plugin): fall back to shasum when sha256sum is missing (macOS) - #15
Merged
Merged
Conversation
bootstrap.sh hashed its stamp with sha256sum, which macOS does not ship unless coreutils is installed; the SessionStart hook then failed with 'sha256sum: command not found' (exit 127) and the plugin could not build its environment. Use sha256sum when present, else shasum -a 256: same digest. tests/test_claude_plugin.py, which runs the script with PATH=/usr/bin:/bin, now passes in full on macOS (it failed 2 of 14 before); its stamp check compares against hashlib, so the digest is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
scripts/claude-plugin/bootstrap.shhashes its stamp withsha256sum. macOS shipsshasuminstead, and has nosha256sumunless coreutils is installed. On such a Mac the SessionStart hook fails withsha256sum: command not found(exit 127), and the plugin cannot build its environment.What
Use
sha256sumwhen it is present, elseshasum -a 256. Both print the same digest.Verified
tests/test_claude_plugin.pyruns the script withPATH=/usr/bin:/bin. It now passes in full on macOS: 14/14, where 2 failed before. Its stamp check compares againsthashlib, so the digest is unchanged.