Repository navigation
feat(native): docs, gate wiring, CodeQL triage, and fixes the gates found (phase 6) - #13
Merged
Merged
Conversation
unohee
force-pushed
the
feat/native-wait-observe
branch
from
October 25, 2026 04:02
d5c7a05 to
e11eb95
Compare
…ound (phase 6)
Docs: README "Drivers" says what native is, what it does differently (no
Runtime.enable, sandbox on, cdp guard, Playwright's switches) and, measured,
that it is not at parity yet; VEGA_INTEGRATION.md describes the no-Playwright
path. Measured: the native real-browser runs pass with playwright and
patchright blocked from importing, and no Playwright module loads.
Gates: build_tools takes LYRA_BROWSER_DRIVER and the gates with their own
--driver flag accept "native", so the repo's gates run on it; the downloads
gate's temp-dir scan also looks in the native driver's parking dir, without
which its "nothing left behind" checks passed vacuously on native.
scripts/verify_native_parity_e2e.py compares the tree view with Playwright's.
Fixes from running the gates on native:
- evaluate decides function vs expression in the browser, as Playwright
does: an IIFE "(() => {...})()" was called as a function and failed;
- Emulation.setFocusEmulationEnabled per page, as Playwright does: a key
press with nothing focused never reached the page;
- Page.aria_snapshot for the whole document;
- the download parking dir follows TMPDIR as it is at launch.
CodeQL (python-security-and-quality, SARIF in /tmp/lyra-codeql/lyra.sarif):
165 results, 41 under src/. Real defects in the native code: 0; two
intentionally empty excepts now say why, one needless lambda removed.
Noise: 20 cyclic imports (every reverse import is under TYPE_CHECKING;
measured, each module imports first on its own), a function import flagged
as a mutable attribute, results from worktrees/ and testing/ copies, and
dev-script findings on loopback test servers. Outside this change: the
/proc reads in uat/procs.py leave closing to the refcount (minor).
Verified: pytest 1755 passed (2 pre-existing macOS sha256sum failures
deselected); the phase 1-5 real-browser runs and the parity script pass.
Gates on native vs playwright (both cdp guard) are in the PR.
unohee
force-pushed
the
feat/native-rollout-docs
branch
from
October 25, 2026 04:03
b2bbf85 to
1af6429
Compare
unohee
marked this pull request as ready for review
October 25, 2026 04:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #12. This is phase 6 of the plan. The native driver is not at parity yet: the repo's own gates, run on it, found gaps (table below). The default driver does not change in this PR.
What
docs/VEGA_INTEGRATION.mddescribes the path without Playwright.playwrightandpatchrightblocked from importing, and no Playwright module gets loaded.build_toolsreadsLYRA_BROWSER_DRIVER, and the gates that take--drivernow acceptnative.scripts/verify_native_parity_e2e.py.Page.aria_snapshot.TMPDIR.CodeQL (python-security-and-quality)
[real defects in native code: 0 / noise: 41 under
src/]TYPE_CHECKING; each module was imported on its own first to confirm.raiseand Protocol stub bodies, both in existing code.worktrees/andtesting/.exceptblocks now carry a comment, and one needless lambda is gone.uat/procs.pyreads/procfiles and leaves closing them to refcounting (minor).Gates: native vs. playwright, both with the cdp guard (2026-10-23, Chrome 155, macOS)
context.set_default_timeoutpage.input_value(called by the gate itself)beforeunloadpage answersneeds_approvalpage.contentinternal:control=enter-frameselector is unsupportedcontext.set_default_timeout* run with
--driver native; the rest withLYRA_BROWSER_DRIVER=native. The Playwright failures in the table also happen without native: they are this machine's baseline.