Repository navigation
fix(daemon): close review findings on the S6 stack (#838-#846) - #847
Merged
Merged
Conversation
Fingerprint now ignores the appended comment history so an unchanged issue stays held, and a declined draft is kept on the task so the pre-claim hold can see it. Fences reach ollama-cloud direct, tester, documenter, auditor, skill-documenter and openswarm work. Provider switches and fanout candidates obey the delegated-adapter policy. exec answer rejects --text without --correlation, redeploys to the run's project, and releases a hold when the deploy is refused. The disk gate also measures the state DB volume.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Findings from a max-effort review of the unreleased S6 stack. Only defects that needed no design decision are fixed here.
Defects in the stack's own gates
ask_humanpark that idle fill used to release by accident is now resumed explicitly.resolveTaskFileScopedropped every draft that was not a sufficient brief, so a confidenthuman_action_only/decision_pendingverdict never reachedholdDeclinedBeforeClaim. The verdict is now kept on the task (scope stays unknown). The fail-closed fallback no longer re-admits a held issue.Fences that did not reach every entry point
openswarm worknow receiveworkerSandbox/forbidPublication./api/provider, saved override on boot,openswarm provider) andfanoutcandidates, andallowDelegatedAdaptersis mapped to the runner.config.example.yamlno longer listscursorinadapterRouting.fallbacks, which the daemon refuses to start with.exec
exec answer --textwithout--correlationis rejected (exit 2) instead of silently dropping the text.project_path, notprocess.cwd().{error}under--json).Other: disk gate also measures the state DB volume; doc/comment corrections;
.gitignoregains.env.*andnohup.out.Behaviour changes to be aware of
Delegated-adapter switches return 403 without
allowDelegatedAdapters; a saved override that violates the policy is ignored with a warning on boot;workerSandbox: onon a host with no sandbox now refuses bash in the stages above too; decline-draft issues are held before the claim.Verification
npm run cipasses. Fulltest:coverageon this tree: 7895 passed, 1 failed insrc/verify/runner.test.ts(baseStatus: 'infra'). The failing verify test differs run to run (2 different ones on feat(daemon): dispatch only Todo and stop declined issues before the claim (AGT-4784) #846's tree, a third here); each passes alone and this diff touches nothing undersrc/verify. No timeout was changed.execCommand.test.tswas over the 1500-line cap; therunExecGuardedblock moved toexecGuarded.test.ts.Not fixed (design decisions, tracked separately)
Worker loopback reaching the daemon's unauthenticated mutating API;
web_fetchegress and pipeline entry points without fences (PR remediation, conflictResolver,/api/exec,openswarm run); disk-gate deadlock with protectedRETRY_ATworktrees; credential exposure outside the sandbox; Backlog children of a decomposition never reaching Todo; AF_UNIX blocked under the loopback profile.The
cli.tswiring of the four exec actions is covered by typecheck only (cli.tsis outside coverage).