Skip to content

Action create improvements #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ryun1 merged 4 commits into from
Apr 27, 2026
Merged

Action create improvements #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b309d36
add additional check for invalid bech32 encoding
Ryun1 Apr 26, 2026
3ed88dd
add warning/sanity check for deposit
Ryun1 Apr 26, 2026
56a779e
add same check to info create
Ryun1 Apr 26, 2026
e69b0b6
add on-chain check for deposit
Ryun1 Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions scripts/action-create-info.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,24 @@ check_field "reward_account" "$deposit_return"
deposit=$(jq -r '.body.onChain.deposit' "$input_file")
check_field "deposit" "$deposit"

# Sanity-check the deposit magnitude. The current Cardano governance action
# deposit is 100,000 ada = 100_000_000_000 lovelace.
EXPECTED_DEPOSIT_LOVELACE="100000000000"
if [ "$deposit" != "$EXPECTED_DEPOSIT_LOVELACE" ]; then
echo -e "${YELLOW}Warning: body.onChain.deposit = ${BRIGHTWHITE}$deposit${YELLOW} lovelace, expected ${BRIGHTWHITE}$EXPECTED_DEPOSIT_LOVELACE${YELLOW} (100,000 ADA, the current governance action deposit). Verify this is intentional before submitting.${NC}" >&2
fi

# Authoritative deposit check against the live protocol parameter
echo "Checking that deposit matches the current protocol parameter"
onchain_deposit=$(cardano-cli conway query protocol-parameters | jq -r '.govActionDeposit')
if [ "$deposit" = "$onchain_deposit" ]; then
echo -e "${GREEN}Metadata has expected deposit amount${NC}"
else
echo -e "${RED}Metadata does not have expected deposit amount${NC}" >&2
echo -e "${RED}Expected: $onchain_deposit found: $deposit${NC}" >&2
exit 1
fi

authors=$(jq -r '.authors' "$input_file")
check_field "authors" "$authors"
witness=$(jq -r '.authors[0].witness' "$input_file")
Expand All @@ -181,17 +199,6 @@ if [ ! -z "$deposit_return_address_input" ]; then
fi
fi

if [ ! -z "$deposit" ]; then
echo "Checking that deposit is the smame amount as current protocol parameter"
onchain_deposit=$(cardano-cli conway query protocol-parameters | jq -r '.govActionDeposit')
if [ "$deposit" = "$onchain_deposit" ]; then
echo -e "${GREEN}Metadata has expected deposit amount${NC}"
else
echo -e "${RED}Metadata does not have expected deposit amount${NC}"
echo -e "${RED}Expected: $onchain_deposit found: $deposit${NC}"
exit 1
fi
fi
# use bech32 prefix to determine if addresses are mainnet or testnet
is_stake_address_mainnet() {
local address="$1"
Expand Down
41 changes: 40 additions & 1 deletion scripts/action-create-tw.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ echo -e "${CYAN}Doing some basic validation and checks on metadata${NC}"
check_field() {
local field_name="$1"
local field_value="$2"

if [ -z "$field_value" ] || [ "$field_value" = "null" ]; then
echo -e "${RED}Error: Required field '$field_name' not found in metadata${NC}" >&2
exit 1
Expand All @@ -185,6 +185,24 @@ check_field "reward_account" "$deposit_return"
deposit_amount=$(jq -r '.body.onChain.deposit' "$input_file")
check_field "deposit" "$deposit_amount"

# Sanity-check the deposit magnitude. The current Cardano governance action
# deposit is 100,000 ada = 100_000_000_000 lovelace.
EXPECTED_DEPOSIT_LOVELACE="100000000000"
if [ "$deposit_amount" != "$EXPECTED_DEPOSIT_LOVELACE" ]; then
echo -e "${YELLOW}Warning: body.onChain.deposit = ${BRIGHTWHITE}$deposit_amount${YELLOW} lovelace, expected ${BRIGHTWHITE}$EXPECTED_DEPOSIT_LOVELACE${YELLOW} (100,000 ADA, the current governance action deposit). Verify this is intentional before submitting.${NC}" >&2
fi

# Authoritative deposit check against the live protocol parameter
echo "Checking that deposit matches the current protocol parameter"
onchain_deposit=$(cardano-cli conway query protocol-parameters | jq -r '.govActionDeposit')
if [ "$deposit_amount" = "$onchain_deposit" ]; then
echo -e "${GREEN}Metadata has expected deposit amount${NC}"
else
echo -e "${RED}Metadata does not have expected deposit amount${NC}" >&2
echo -e "${RED}Expected: $onchain_deposit found: $deposit_amount${NC}" >&2
exit 1
fi

withdrawal_list=$(jq -r '.body.onChain.gov_action.rewards' "$input_file")
check_field "rewards" "$withdrawal_list"

Expand Down Expand Up @@ -231,6 +249,27 @@ if [ ! -z "$withdrawal_address_input" ]; then
fi
fi

# Verify bech32 integrity (checksum + address type) of stake address
validate_stake_address() {
local label="$1"
local address="$2"
local info
if ! info=$(cardano-cli address info --address "$address" 2>&1); then
echo -e "${RED}Error: $label is not a valid bech32 address: ${YELLOW}$address${NC}" >&2
echo -e "${GRAY}cardano-cli rejected it: $info${NC}" >&2
exit 1
fi
local addr_type
addr_type=$(echo "$info" | jq -r '.type // ""')
if [ "$addr_type" != "stake" ]; then
echo -e "${RED}Error: $label is bech32-valid but is not a stake address (type=${YELLOW}${addr_type:-unknown}${RED}): ${YELLOW}$address${NC}" >&2
exit 1
fi
}

validate_stake_address "metadata body.onChain.reward_account" "$deposit_return"
validate_stake_address "metadata body.onChain.gov_action.rewards[0].key" "$withdrawal_address"

# use bech32 prefix to determine if addresses are mainnet or testnet
is_stake_address_mainnet() {
local address="$1"
Expand Down