feat(provider): implement fullProtocolParameters support for transaction builds#310
Open
Mavis2103 wants to merge 2 commits intoIntersectMBO:mainfrom
Open
feat(provider): implement fullProtocolParameters support for transaction builds#310Mavis2103 wants to merge 2 commits intoIntersectMBO:mainfrom
Mavis2103 wants to merge 2 commits intoIntersectMBO:mainfrom
Conversation
…opose, and stake modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
fullProtocolParametersoption to the transaction builder, allowing all protocol parameters to be overridden in a single place. It updates the builder internals and all relevant operations to use this new option for protocol parameter resolution, improving efficiency and flexibility—especially when a provider is not available. The changes also ensure all builder programs have access to build options via dependency injection.Protocol parameters override and resolution:
fullProtocolParametersfield toBuildOptions, deprecating the oldprotocolParametersfor fee calculation and enabling full protocol parameter overrides for all builder operations.resolveProtocolParametersto prioritizefullProtocolParametersif present, falling back to provider or legacy options as needed.fullProtocolParametersfor deposit and fee calculations, removing direct provider dependency where possible. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Dependency injection and type improvements:
BuildOptionsTagin their effect environment, so build options are always available.BuildOptionsTag. [1] [2] [3] [4]Internal refactoring and minor cleanup:
makeTxBuilderoverloads for better readability.txBuilder.tsand related files. [1] [2]These changes make protocol parameter management more robust and flexible, reduce unnecessary provider calls, and streamline transaction building for advanced use cases.