cardano-testnet: declare supported cli/node versions#6549
Conversation
Jimbo4350
left a comment
There was a problem hiding this comment.
We should implement a golden test for this.
a54b5a7 to
3f77060
Compare
3f77060 to
74c417f
Compare
74c417f to
1fd4c55
Compare
@Jimbo4350, I've added a golden test in the latest commit. But, in retrospective, I am not sure it was a good idea. Because it needs to be changed in each bump. And I already deleted two lines to avoid the git rev (which would need to be changed in every commit), and the architecture (which would just never match), as well as the |
How do you suggest we police that the correct versions make it into the binary? |
I didn't know that was the goal. I hear |
Description
Declares which
cardano-cli\andcardano-nodeversionscardano-testnetsupports,via two zero-maintenance mechanisms:
README "Supported versions" section — states the single-release policy:
use cli and node from the same release tarball as cardano-testnet.
Extended
cardano-testnet versionoutput — reports thecardano-apiandcardano-cliversions the build was compiled against, using Cabal'sauto-generated
VERSION_cardano_apiandVERSION_cardano_cliCPP macros.The cabal file remains the sole source of truth.
Also fixes the version banner which incorrectly said "cardano-node" instead of
"cardano-testnet".
Closes #6548
Checklist
See Running tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12