Skip to content

cardano-testnet: declare supported cli/node versions#6549

Merged
palas merged 4 commits intomasterfrom
tag-testnet-compatibility
Apr 27, 2026
Merged

cardano-testnet: declare supported cli/node versions#6549
palas merged 4 commits intomasterfrom
tag-testnet-compatibility

Conversation

@palas
Copy link
Copy Markdown
Contributor

@palas palas commented Apr 24, 2026

Description

Declares which cardano-cli\ and cardano-node versions cardano-testnet supports,
via two zero-maintenance mechanisms:

  1. README "Supported versions" section — states the single-release policy:
    use cli and node from the same release tarball as cardano-testnet.

  2. Extended cardano-testnet version output — reports the cardano-api and
    cardano-cli versions the build was compiled against, using Cabal's
    auto-generated VERSION_cardano_api and VERSION_cardano_cli CPP macros.
    The cabal file remains the sole source of truth.

Also fixes the version banner which incorrectly said "cardano-node" instead of
"cardano-testnet".

Closes #6548

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Running tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

@palas palas requested a review from a team as a code owner April 24, 2026 00:00
@palas palas requested review from mkoura and removed request for a team April 24, 2026 00:00
@palas palas self-assigned this Apr 24, 2026
Copy link
Copy Markdown
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should implement a golden test for this.

Comment thread cardano-testnet/src/Parsers/Version.hs Outdated
@palas palas force-pushed the tag-testnet-compatibility branch from a54b5a7 to 3f77060 Compare April 24, 2026 14:37
@palas palas force-pushed the tag-testnet-compatibility branch from 3f77060 to 74c417f Compare April 24, 2026 14:37
@palas palas force-pushed the tag-testnet-compatibility branch from 74c417f to 1fd4c55 Compare April 24, 2026 14:37
@palas palas requested a review from Jimbo4350 April 24, 2026 14:38
@palas
Copy link
Copy Markdown
Contributor Author

palas commented Apr 24, 2026

We should implement a golden test for this.

@Jimbo4350, I've added a golden test in the latest commit. But, in retrospective, I am not sure it was a good idea. Because it needs to be changed in each bump. And I already deleted two lines to avoid the git rev (which would need to be changed in every commit), and the architecture (which would just never match), as well as the cardano-node version

@Jimbo4350
Copy link
Copy Markdown
Contributor

We should implement a golden test for this.

@Jimbo4350, I've added a golden test in the latest commit. But, in retrospective, I am not sure it was a good idea. Because it needs to be changed in each bump. And I already deleted two lines to avoid the git rev (which would need to be changed in every commit), and the architecture (which would just never match), as well as the cardano-node version

How do you suggest we police that the correct versions make it into the binary?

Copy link
Copy Markdown
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@palas
Copy link
Copy Markdown
Contributor Author

palas commented Apr 27, 2026

How do you suggest we police that the correct versions make it into the binary?

I didn't know that was the goal. I hear cardano-node release is pretty tricky, so if this helps, then by all means. I guess that, in any case, it is good that it is obvious when the key dependencies have changed, that way it is harder that it happens by accident

@palas palas added this pull request to the merge queue Apr 27, 2026
Merged via the queue into master with commit 591bfc9 Apr 27, 2026
29 checks passed
@palas palas deleted the tag-testnet-compatibility branch April 27, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cardano-testnet: declare supported cli/node versions via README + --version output

2 participants