Repository navigation
Pin GitHub Actions to commit SHAs and test the oldest Node - #6
Merged
Merged
Conversation
Each action now points to a full commit SHA with its release tag in a comment, so a moved tag cannot change what runs; Dependabot updates the SHA and the comment together. The pull request build now runs on Node 22.23.4, the oldest version package.json allows, as well as on Node 24.
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin every GitHub Action reference to a full commit SHA and run the pull request build on the oldest Node that package.json allows as well as on Node 24.
Changes
uses:in.github/workflowspoints to a commit SHA with the release tag in a trailing comment. Dependabot (github-actions, weekly) updates the SHA and the comment together. Actions that these actions call internally are not covered by the pin.pr-build.ymlruns as a matrix over Node 22.23.4 (enginesfloor) and 24. The deploy stays on Node 24.Validation
gh api repos/<action>/git/ref/tags/<tag>(annotated tags dereferenced) andgh api repos/<action>/commits/<sha>match for the 4 pins this repo uses.actionlint1.7.12 on the branch: no findings.