Repository navigation
COMP: Detect a workflow that can never be scheduled - #94
hjmjohnson wants to merge 1 commit into
Conversation
c8ee791 to
268e6c7
Compare
268e6c7 to
1dd4619
Compare
|
Restacked onto |
be1e2d5 to
6581cec
Compare
1dd4619 to
e96256a
Compare
|
Force-push: plain rebase onto the rebased #93; the single commit is unchanged. |
seanm
left a comment
There was a problem hiding this comment.
I defer to others on this one, github CI is not my thing...
gdevenyi
left a comment
There was a problem hiding this comment.
Review by Google Carbon
Verdict: Request Changes (Draft; unstack from #93 onto #89 + fix 3 script edge cases)
Great idea catching dead workflow triggers like build.yml's branches: [ main ] automatically!
- Unstack onto
masteronce#89lands: This PR has no technical dependency on#92or#93(whose base currently conflicts withmaster); it only needs#89'smain -> masterfix in.github/workflows/build.yml. - Fix 3 edge cases in
.github/check_workflow_triggers.py(detailed inline):- Silent
return 0(green check) whenexisting_branches()comes back empty on detached-HEAD PR checkouts ifgit ls-remotefails. TypeErrorcrash when YAML 1.1 parses unquoted branch names likeon(bool) or3.0(float), or char-by-char iteration ifbranches: masteris written as a bare string.- Including
'!'inGLOB_CHARSskips the entirebranches:list whenever any!excludefilter is present (allowingbranches: [ main, '!wip' ]or invalid negative-onlybranches: [ '!wip' ]to pass silently).
- Silent
6f7552f to
8514828
Compare
e96256a to
ee08e7b
Compare
A branch filter naming a branch that does not exist leaves the workflow configured but never run, which looks the same as one that runs and passes: no red check appears because no check appears at all. build.yml sat dead behind a filter naming main on a repository whose branch is master, and the only thing that found it was reading the file. The check judges a filter only when its positive entries are all literal names, flags a filter of only !exclusions or of unquoted non-string entries, and fails in CI when it cannot list the branches. Its tests run in the same job.
ee08e7b to
6c09474
Compare
Re-submission of #83, reverted from
masteron 2026-09-24 so it can bereviewed before merging. Content is unchanged from the original.
Stacked on #93 (
ci/windows), notmaster. The diff shown here is this change alone: the check script and the oneworkflow-triggersjob. Merge #93 and the PRs below it first.The workflows only trigger for pull requests whose base is
master, so no CI runs on this PR until its base reachesmaster. Run locally on this base,DEFAULT_BRANCH=master python3 .github/check_workflow_triggers.pypasses, becausebuild.ymlhere already namesmaster.Ordering for this stack (as of 2026-11-03)
ci/install-linking-srcdirmasterci/test-output-on-failuremasterci/guard-cmp0169ci/test-output-on-failureci/build-all-codepathsmasterci/widen-coverageci/build-all-codepathspr/fix-missing-prototypesmasterfix/buildyml-jobsmasterci/missing-declarationsmasterci/windowsci/missing-declarationsci/workflow-trigger-lintci/windowsThe order is the order these changes sat on
masterbefore the revert, soit is known to build and test at every step. Verified again after
rebuilding the stack: the tip configures, compiles with no errors, and
passes 344/344 tests.
Why this one is stacked rather than independent
Each PR in this chain edits the same few files as its predecessors, chiefly
.github/workflows/cmake-multi-platform.yml,cmake/exported_symbols_linux.txtand
cifti/afni_xml.h. Cherry-picked ontomasteralone, the later onesconflict. Two members also carry a build-order dependency rather than a
textual one: without #30 the project does not configure at all on CMake
versions that do not know policy CMP0169, and #29 is needed for
install_linkingto find its source directory.Commits
See #84 for the ordering of all 49 re-submitted pull requests.