Repository navigation
feat(template): command and mountPath, release 0.1.17 - #327
Merged
Merged
Conversation
jwfing
reviewed
Oct 1, 2026
jwfing
left a comment
Member
There was a problem hiding this comment.
Summary
The change correctly adds command and mountPath support while preserving legacy /data rendering behavior.
Requirements context
Intent was derived from the PR description and the repository’s statement that local validation mirrors the platform’s authoritative template parser (src/template-manifest.ts:1-7). No separate in-repo design document or linked issue was found; the referenced private platform PR was unavailable from this environment. This is a manifest-schema change, not a command/flag change, so the CLI-reference mirroring requirement does not apply.
Findings
Critical
(none)
Suggestion
(none)
Information
- Software engineering / functionality: The implementation declares both runtime fields, rejects them on all managed datastore types, validates non-empty commands and absolute volume-backed mount paths, and preserves the manifest for submission (
src/template-manifest.ts:25-36,src/template-manifest.ts:134-197). Tests cover valid fields, invalid shapes, every managed datastore, custom rendering, and the/datafallback (test/template.test.ts:143-151,test/template.test.ts:319-326,test/template.test.ts:398-405). - Compatibility: Template info accepts both array and map service shapes, retains legacy
volumeGibhandling, and falls back to/datawhen no custom path exists (src/commands/template.ts:42-57,src/commands/template.ts:93-102). - Security: No security-relevant regression found. The CLI validates and forwards the intended runtime strings but does not execute
commandlocally; there are no authentication, secret-handling, dependency, SQL, or local shell-execution changes (src/template-manifest.ts:190-197). - Performance: No performance concerns. The additions are constant-time checks within the existing per-service validation and rendering passes (
src/template-manifest.ts:124-198,src/commands/template.ts:93-102). - Verification:
git diff --checkpassed. The repository typecheck/test gate could not run becausenode_modulesis absent andtscis unavailable; no dependency installation was performed in this read-only review (package.json:30-33).
Verdict
Approved — no Critical findings.
….17 (main is at 0.1.16)
CarmenDou
marked this pull request as ready for review
October 2, 2026 00:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add local validation for two optional service runtime fields that the platform's provisioning layer supports:
command(non-empty string, entrypoint override) andmountPath(absolute path for volume mount, requiresvolume: true). Refuse both fields on managed datastores (postgres, redis, mysql, mongodb) matching platform behavior.Also display
mountPathin thetemplate infooutput when present, falling back to the default/datamount point for manifests authored before this release.How
ManifestServicetype to includecommandandmountPathfields insrc/template-manifest.tscommandandmountPathto the managed datastore bare-field list to refuse them on postgres/redis/mysql/mongodb servicesnormalizeInfoServicesinsrc/commands/template.tsto copymountPathfrom service specstemplateInfoLinesto render the service'smountPathinstead of hardcoded/dataVerify
Verified on Node 22.23.3 with PATH="/Users/carmen/.claude/jobs/e0bc4f26/tmp/node-v22.23.3-darwin-arm64/bin:$PATH":
npx vitest run test/template.test.ts -t "managed datastore": passed (3 tests covering postgres/redis/mysql/mongodb refusing command and mountPath)npx vitest run test/template.test.ts: passed (89 tests, 22ms)npm run typecheck: passed (no TypeScript errors)npm test: passed (95 test files, 1943 tests, 18.57s)Template info now renders custom mount paths correctly:
volume: true, mountPath: '/app/storage'renders aspersistent /app/storagevolume: trueand no mountPath still renders aspersistent /dataManaged datastore validation:
commandandmountPathwith "carries no" messageThis PR merges after insta-platform#593 is deployed. The
v0.1.17tag is pushed after merge (main had already released 0.1.15 and 0.1.16).