Skip to content

Feat: Ppt button preview#565

Closed
CJKmkp wants to merge 7 commits into
net6from
feat/PPT-button-preview
Closed

Feat: Ppt button preview#565
CJKmkp wants to merge 7 commits into
net6from
feat/PPT-button-preview

Conversation

@CJKmkp

@CJKmkp CJKmkp commented Jun 28, 2026

Copy link
Copy Markdown
Member

No description provided.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@augmentcode

augmentcode Bot commented Jun 28, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Adds a dedicated settings subpage for PowerPoint page-turn (flip) buttons with an in-page visual preview.

Changes:

  • Introduced PPTFlipButtonSettingsPage (XAML + code-behind) that previews all four button positions and exposes per-position settings (enable, offset, opacity, page number, background) plus global options.
  • Refactored PowerPointPage to replace the large inline flip-button configuration UI with a single “Configure” entry that navigates to the new subpage.
  • Registered the new page in SettingsWindow navigation maps so it can be routed via NavigateToPage.
  • Added new localized resource strings (zh-CN default, zh-ME, en-US) for the new UI labels and hint text.

Technical Notes: The preview renders PPTNavBar instances scaled/positioned from persisted PowerPointSettings, and updates propagate through SettingsManager plus SettingsActionHub notifications.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

{
var str = ppt.PPTSButtonsOption.ToString();
char[] c = str.ToCharArray();
c[0] = CheckboxShowPageNumber.IsChecked == true ? '2' : '1';

@augmentcode augmentcode Bot Jun 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CheckboxShowPageNumber_Changed (and similarly CheckboxBlackBackground_Changed) indexes directly into PPTSButtonsOption/PPTBButtonsOption char arrays (e.g., c[0], c[2]) without validating length; if an older/manual-edited settings value stringifies to fewer digits, this can throw IndexOutOfRangeException and break the settings UI.

Severity: medium

Other Locations
  • Ink Canvas/Windows/SettingsViews/Pages/PPTFlipButtonSettingsPage.xaml.cs:423

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

PrefacedCorg and others added 6 commits June 28, 2026 11:26
新增 FixedAspectRatioPanel 在父容器内计算最大 16:9 矩形,替换原 Viewbox 缩放方案;预览画布按实际尺寸排列子元素,翻页按钮 Border 的 Margin 按视图缩放比例计算,避免缩放变换导致的模糊与尺寸失真。
PPTFlipButtonSettingsPage 移除返回按钮与位置复选框,新增 InfoBar 操作提示,进入页面时切换 NavigationView 为 LeftMinimal 以扩展预览空间并在离开时恢复;BoardToolbarPage/ToolbarPage 配置操作按钮由 StackPanel+Margin 改为 SimpleStackPanel+Spacing,移除各页恢复默认按钮的显式 Padding 统一为样式默认值。
移除翻页按钮设置卡片内的独立配置按钮,改为 SettingsCard IsClickEnabled 整体可点击跳转。
@CJKmkp

CJKmkp commented Jun 28, 2026

Copy link
Copy Markdown
Member Author

啊这

@AstrZero AstrZero closed this Jun 28, 2026
@AstrZero AstrZero deleted the feat/PPT-button-preview branch June 28, 2026 10:13
@AstrZero AstrZero restored the feat/PPT-button-preview branch June 28, 2026 10:14
@AstrZero AstrZero deleted the feat/PPT-button-preview branch June 28, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants