Skip to content

improve:UI#564

Closed
CJKmkp wants to merge 2 commits into
net6from
improve-ui
Closed

improve:UI#564
CJKmkp wants to merge 2 commits into
net6from
improve-ui

Conversation

@CJKmkp

@CJKmkp CJKmkp commented Jun 27, 2026

Copy link
Copy Markdown
Member

No description provided.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@augmentcode

augmentcode Bot commented Jun 27, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR improves the Settings UI by introducing a dedicated settings search page and wiring it into the existing Settings window search box.

Changes:

  • Added a new SearchPage (XAML + code-behind) with an AutoSuggestBox, hint text, and keyboard handling.
  • Implemented suggestion generation and query submission logic to select a matching settings entry and emit a selection event.
  • Extended SettingsWindow navigation to include SearchPage and navigate to it when the header search box receives focus.
  • Built/propagated a search index (_searchIndex) into SearchPage.SearchData and added a callback (SearchPage.ResultSelected) to navigate to results or go back.

Technical Notes: Search data is passed via a static property/event on SearchPage, with explicit subscribe/unsubscribe in SettingsWindow lifecycle to avoid lingering handlers.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

string query = sender.Text?.Trim() ?? string.Empty;
if (string.IsNullOrEmpty(query))
{
sender.ItemsSource = null;

@augmentcode augmentcode Bot Jun 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the query becomes empty, ItemsSource is cleared but IsSuggestionListOpen isn’t explicitly closed, so the suggestion popup can remain open from a previous non-empty query (empty dropdown UI glitch).

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

SearchPage.SearchData = _searchIndex
.Select(se => (se.Text, se.PageTag))
.ToList();
NavigateToPage("SearchPage");

@augmentcode augmentcode Bot Jun 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OnControlsSearchBoxGotFocus always navigates to SearchPage; if focus returns to controlsSearchBox after rootFrame.GoBack() (e.g., ESC on SearchPage), this can immediately re-navigate and make “back” hard/impossible. Consider guarding against re-entry or ensuring focus moves away when returning.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@CJKmkp CJKmkp closed this Jun 28, 2026
@CJKmkp CJKmkp deleted the improve-ui branch June 28, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant