improve:UI#564
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
🤖 Augment PR SummarySummary: This PR improves the Settings UI by introducing a dedicated settings search page and wiring it into the existing Settings window search box. Changes:
Technical Notes: Search data is passed via a static property/event on 🤖 Was this summary useful? React with 👍 or 👎 |
| string query = sender.Text?.Trim() ?? string.Empty; | ||
| if (string.IsNullOrEmpty(query)) | ||
| { | ||
| sender.ItemsSource = null; |
There was a problem hiding this comment.
| SearchPage.SearchData = _searchIndex | ||
| .Select(se => (se.Text, se.PageTag)) | ||
| .ToList(); | ||
| NavigateToPage("SearchPage"); |
There was a problem hiding this comment.
OnControlsSearchBoxGotFocus always navigates to SearchPage; if focus returns to controlsSearchBox after rootFrame.GoBack() (e.g., ESC on SearchPage), this can immediately re-navigate and make “back” hard/impossible. Consider guarding against re-entry or ensuring focus moves away when returning.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Update prcheck.yml
No description provided.