Skip to content

fix(doc): vague verification description on MakerFeeRate and TakerFeeRate #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chen4903 wants to merge 1 commit into
base: release/v1.18.x
Choose a base branch
from
Open

fix(doc): vague verification description on MakerFeeRate and TakerFeeRate #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions injective-chain/modules/exchange/spec/04_state_transitions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ The update of spot market param is handled by `SpotMarketParamUpdateProposal` wh
- `ValidateBasic` for proposal
- Get spot market by `p.MarketId` and if not exist, revert
- Reset the params for `MakerFeeRate`, `TakerFeeRate`, `RelayerFeeShareRate`, `MinPriceTickSize`, `MinQuantityTickSize` and `Status` if not empty, if empty keep as it is.
- Validate `MakerFeeRate` is bigger than `TakerFeeRate`.
- Validate that `MakerFeeRate` should not be bigger than `TakerFeeRate`.

## Derivative market param update proposal

Expand All @@ -405,7 +405,7 @@ Derivative market param update is handled by `DerivativeMarketParamUpdateProposa
- `ValidateBasic` for proposal
- Validate Derivative market exists by `p.MarketId` and if not exist, revert
- Reset the params for `InitialMarginRatio`, `MaintenanceMarginRatio`, `MakerFeeRate`, `TakerFeeRate`, `RelayerFeeShareRate`, `MinPriceTickSize`, `MinQuantityTickSize` and `Status` if not empty, if empty keep as it is.
- Validate `MakerFeeRate` is bigger than `TakerFeeRate`.
- Validate that `MakerFeeRate` should not be bigger than `TakerFeeRate`.
- Validate `InitialMarginRatio` is bigger than `MaintenanceMarginRatio`.
- Schedule Derivative market param update and update finalization on Endblocker - **Note:** this is due to the orders update for derivative market param update - should make sure nothing panics here.

Expand Down