Repository navigation
Conversation
Agent-assisted-by: Claude Code (author) Signed-off-by: GUOGUO <xwdong1998@163.com>
Agent-assisted-by: Claude Code (author) Signed-off-by: GUOGUO <xwdong1998@163.com>
amy-why-3459
approved these changes
Nov 15, 2026
amy-why-3459
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base cd8fcb452bd2c7969a7a6e2544aa1cb5f8ad5332 and head def0557ff99ddc804a7084710003eb5a80b7e04b (source checkpoint 23fc2a2ad21d4d9600780aa20daed2ebc9fb7eba, then the docs-only commit).
This also covers the formal architecture review of the docs/legacy-knowledge-manifest.json C2 relock requested in #451:
src/inferrsi/resources/repository_packs.pyis byte-identical to the retired root_repo_pack_data.py. SHA-256751d7bf663318962a2e73cf9d75369e0f8f8c2bda27964c56e44021b9f86c992matchestechnical_leaf.file_sha256and both sides ofmodule_path_revision.- The leaf module/file,
neutral_leaf_export, and thecatalog/infra.inspectionpair targets all point atinferrsi.resources.repository_packs. The nine-pair count is unchanged, and no pair remains oninferrsi._repo_pack_data. - The importlib anchor, allowed imports, two symbols, and
REPO_TYPESobject identity acrosscatalog,knowledge.catalog, andargumentsare preserved.resources/__init__.pyis import-free.contracts.evidenceonly builds paths;ensure_evidence_layoutlives inapps.evidence_layoutwith the samemkdir(parents=True, exist_ok=True)call. The two old root modules are gone with no alias, and the exact root inventory shrinks 23 → 21. - Hosted CI on this head is green, including
full-checkandinstalled-packageon 3.10 and 3.11. I did not independently re-run the author's outside-checkout wheel install.
No blocking findings. The issue stays open, as this PR does not close #451.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Refs #451 — C2 in the accepted eight-PR sequence; this does not close the issue.
resources/repository_packs.py, with an import-free parent, one shared seven-entryREPO_TYPESobject, and the unchangedfiles("inferrsi").joinpath("harness", "data", "repo_packs", ...)anchor. Pack data stays with its current owner; no Harness/core import or new mandatory dependency.contracts/evidence.pyand directory creation intoapps/evidence_layout.py, preserving signatures, order, errors, and mkdir behaviour. Retire both old root modules in this PR, without shells or aliases; update active consumers and negative import/pickle checks.CHANGELOG.md,docs/architecture.md,docs/module-layout.md, anddocs/contracts/current-design.md, including the retirement/pickle notice and staged/final-boundary distinction. Historical/frozen evidence is not rewritten.R1's eleven old-entry retirements and permanent exact inspection rule are not implemented here; neither are A/M or later loader work. Existing staged isolation blockers remain, rather than prematurely asserting the final gate is clear. The older architecture data block and SVG were not expanded into a separate cleanup.
Independent validation
The tested source checkpoint is
23fc2a2ad21d4d9600780aa20daed2ebc9fb7eba; the final commit is documentation-only, and all 20 tested source/test/manifest path bytes were independently verified unchanged after documentation completion.test_contracts_package,test_evidence_paths,test_first_wave_isolation_policy,test_knowledge_compatibility_shells,test_module_boundaries,test_package_root_inventory,test_repository_packs_facade,test_resource_migration,test_smoke,test_target_module_import_gate).run_store.pyF811 diagnostics are outside this change.tests/check_installed.py, installed C2 semantics and distribution/version-origin checks all exit 0. 929 applicable installed resource files match the baseline bytes; all seven packs, identity/no-core/no-IO/path vectors pass.0.1.11.dev18+g23fc2a2ad; SHA-25674cb649250138a580ee90205b6792990f6dacaf6ca4930f7f1037eeccf2b32e3. This artifact belongs to the source checkpoint above, not a rebuild of the later docs-only head.Preserved environment failures: the first coordinator helper used the Windows default GBK decoder for UTF-8 JSON; only the outside-repository helper encoding was corrected. The first fresh no-deps venv full installed check lacked the project's already-declared optional
[skills]dependencyPyYAML>=6.0; installing that dependency in that venv made the unchanged checker pass. Original failed receipts remain. No checker bypass, global configuration change, dependency-policy change or repeated broad build/test run was used.Git/main and authorship
Base main is
cd8fcb452bd2c7969a7a6e2544aa1cb5f8ad5332(merged PR453, with #450 already in its ancestry), freshly fetched before delivery and unchanged. This branch contains the normal source checkpoint plus one normal documentation commit; no history rewrite or additional merge was necessary.All material changed product/source/test/manifest and documentation content is from the original Claude Code Fable session. Local provenance review replayed successful tool mutations for all 20 source/test/manifest paths from the base (ordinary Git LF/CRLF normalization only). The final four documents were independently written by that same session using Read/Edit only and replay-verified against their saved originals. An unused coordinator documentation draft stayed outside the checkout and was never supplied to the session or applied. The coordinator scoped the task, independently validated/read the results, and performed Git/PR metadata operations; it did not rewrite the product/docs content. No governance exception is sought.
The following model/effort values are the explicitly requested/reported client settings, not independent backend attestation.
Formal architecture/content review and the normal CI/review gates remain pending. No auto-merge or issue closure is requested.