Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evidence and scope
Two exposed historical Direct/cursor/auto findings missed interprocedural evidence:
69211d003019f42578a26c9de3f10c74431323f0, claimed sampling metadata never reached the consumer. The concrete subclass caller supplies it explicitly, and the superclass forwards the kwargs.05916a1fe58f31866c4c29051705269bf9c7279f, proposed unregistering after successful shared-memory unlink. CPython 3.12.13 unlink already unregisters on the POSIX success path. This is version-specific source evidence; the historical deployment interpreter and a runtime duplicate-removal traceback were not established.Both were fallback Direct outputs, not quality evidence for the originally assigned Strict provider. These public cases informed development and are not sealed holdouts. No claim that their other runtime paths are correct.
Change
Add three targeted items to the canonical
DIRECT_REVIEW_CHECKLIST:Add a normal public-SDK regression and update the corresponding SPEC. No new schema, attestation field, finding filter, semantic completion gate, routing/model configuration, bot edit or deployment change. This targets Direct, separately from #449 cancellation ownership and #450 peer-verifier context.
Delivery verification
Base:
2e8123235d2ee58927f973be16efc2600fa8c398.Current bot source was checked at
JiusiServe/omni-reviewbot@43364408d42e100243e3ab40329f9aa425ef0bc2: its Direct adapter returnsplan.to_dict(), the shared Codex prompt embeds the full context JSON, and Cursor calls that same builder withcursor_read_only=True. Updating only the standalone Cursor instructions would miss this path.Six focused offline checks passed using selected production-function ASTs with resource discovery, containment and tracing isolated by doubles:
planmethod and real dataclass serializer.With the original provider source, the five guidance checks fail and the empty-context control passes. This establishes prompt delivery in the isolated functions, not a full-package SDK execution or model compliance. Python 3.12.14 compilation, whitespace checks, unchanged production AST outside the checklist, and scoped SPEC mapping/date checks also pass.
The sparse local snapshot lacks pytest and full-package dependencies. Normal-import execution of the committed regression, full repository tests, installed-wheel checks and whole-tree/history SPEC validation were not run locally; exact-head CI must supply those results. Standalone host contract tests were inspected and impose no checklist-copy requirement.
No model/replay calls, user's Codex execution, live review assignment, retry job, GPU run, merge or deployment was invoked. No measured precision/recall or production quality improvement is claimed. Keep draft pending exact-head CI and a new independent dot review.