You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue is dependent upon #125 . Because to use autocomplete we need a different shell to make our changes visible. That shell can be created by xonsh.
@GouravSardana Instead of using xonsh shell. Won't it be a better idea if there is something like a dynamic-cli REPL or shell which gets activated by running some command in bash like dynamic. And users will enter related commands in the REPL. In this case we can customise autocompletion and all just using prompt_toolkit.
I'm not sure if this will have any disadvantages compared with current way of implementation?
Can you come up with a design for this before implementing?
I was planning to take input from the input stream/console for commands instead of getting them from command line. But the console is just in a formatted way like any other REPL. For this maybe I would need to add some new functions for auto-completion and add the input logic like we do while taking input in any other python program.
Do we get the history or the current folder ? Something like that
Can we integrate in such a way if we type dynamic then only it’ll activate ?
Yes
1 . I didn't get what you meant. But if you are asking about autocomplete based on previous queries that could be done for a single session(I meant till the time user exits the REPL). To remember the previous session's queries for autocomplete is what I was looking for(still not sure about how to implement this)
Got it. I mean we were creating sessions or not. I think it’s clear now. We don’t have to worry about the autocomplete after the session
Please go on and start integrating this first. Will figure it out a way
@GouravSardana I made a pull request. Can you review it? I still need to handle some options/commands properly.
Commands like -help, -file are not yet handled
I would be happy to contribute to the project as I find my skills a good fit for the issue . As a GSSOC 23 member I humbly ask to allow me to contribute to the issue. I firmly believe that I can be a valuable asset.
Restart triage: P3 — separate completion requirements from a new REPL. Current dynamic/main.py has no autocomplete path. PR #172 proposes a broader interactive shell, and the existing discussion leaves command compatibility and normal-shell access unresolved.
Next step: decide whether the requirement is shell completion, in-session command suggestions, history completion or a dedicated REPL. Review #172 against that scope after baseline CLI tests; adopting xonsh in #125 is not automatically required.
Source review only; this was not run or reproduced during triage. Keeping the issue open.
Activity
lainq commentedon Sep 30, 2021
Hmm, that would be a nice addon
kriptonian1 commentedon Mar 1, 2022
Is it like what we have to fetch it from history
GouravSardana commentedon Mar 1, 2022
Nops. Not from the history. We have to make patterns according to what user is typing
shivankar-p commentedon Mar 12, 2022
@GouravSardana I would like to work on this as a GSSOC contributor.
GouravSardana commentedon Mar 12, 2022
Please go ahead @shivankar-p
shivankar-p commentedon Mar 12, 2022
@GouravSardana Instead of using xonsh shell. Won't it be a better idea if there is something like a dynamic-cli REPL or shell which gets activated by running some command in bash like
dynamic. And users will enter related commands in the REPL. In this case we can customise autocompletion and all just using prompt_toolkit.I'm not sure if this will have any disadvantages compared with current way of implementation?
GouravSardana commentedon Mar 12, 2022
Can you come up with a design for this before implementing?
shivankar-p commentedon Mar 12, 2022
I was planning to take input from the input stream/console for commands instead of getting them from command line. But the console is just in a formatted way like any other REPL. For this maybe I would need to add some new functions for auto-completion and add the input logic like we do while taking input in any other python program.
shivankar-p commentedon Mar 12, 2022
Design wise it would look this way. User gets to access this features of dynamic-cli once he enters
dynamic-cliin command lineGouravSardana commentedon Mar 12, 2022
This looks good only. I have 2 concern :
shivankar-p commentedon Mar 12, 2022
1 . I didn't get what you meant. But if you are asking about autocomplete based on previous queries that could be done for a single session(I meant till the time user exits the REPL). To remember the previous session's queries for autocomplete is what I was looking for(still not sure about how to implement this)
GouravSardana commentedon Mar 12, 2022
Got it. I mean we were creating sessions or not. I think it’s clear now. We don’t have to worry about the autocomplete after the session
Please go on and start integrating this first. Will figure it out a way
shivankar-p commentedon Mar 13, 2022
@GouravSardana I made a pull request. Can you review it? I still need to handle some options/commands properly.
Commands like -help, -file are not yet handled
mridul45 commentedon May 20, 2023
I would be happy to contribute to the project as I find my skills a good fit for the issue . As a GSSOC 23 member I humbly ask to allow me to contribute to the issue. I firmly believe that I can be a valuable asset.
GouravSardana commentedon Oct 21, 2026
Restart triage: P3 — separate completion requirements from a new REPL. Current dynamic/main.py has no autocomplete path. PR #172 proposes a broader interactive shell, and the existing discussion leaves command compatibility and normal-shell access unresolved.
Next step: decide whether the requirement is shell completion, in-session command suggestions, history completion or a dedicated REPL. Review #172 against that scope after baseline CLI tests; adopting xonsh in #125 is not automatically required.
Source review only; this was not run or reproduced during triage. Keeping the issue open.